From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQQEv-0006Rb-5H for qemu-devel@nongnu.org; Tue, 24 Feb 2015 19:54:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQQEr-0006ND-Kz for qemu-devel@nongnu.org; Tue, 24 Feb 2015 19:54:13 -0500 Received: from out1134-211.mail.aliyun.com ([42.120.134.211]:23690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQQEr-0006Le-AY for qemu-devel@nongnu.org; Tue, 24 Feb 2015 19:54:09 -0500 Message-ID: <54ED1F04.9050905@sunrus.com.cn> Date: Wed, 25 Feb 2015 09:01:56 +0800 From: Chen Gang S MIME-Version: 1.0 References: <54EC2DEE.8050809@sunrus.com.cn> <54EC88D6.3060402@ezchip.com> <54ECA746.8030804@sunrus.com.cn> <54ECAB00.6000501@ezchip.com> <54ECB3ED.7030100@sunrus.com.cn> <54ECC092.7030105@ezchip.com> In-Reply-To: <54ECC092.7030105@ezchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Metcalf , Peter Maydell , Richard Henderson , "walt@tilera.com" , Riku Voipio Cc: qemu-devel On 2/25/15 02:18, Chris Metcalf wrote: > On 2/24/2015 12:25 PM, Chen Gang S wrote: >> For me, if the raw integer is only used once, we needn't define a macro >> for it (instead of, we can give a comment for it). > > The advantage of names even in this case is that you can group all the > macro definitions in one place where they are easy to read and review. > Then later when you use them they are self-documenting. Yeah, what you said sounds reasonable to me. At present (and originally), I was not quit sure each number's meaning, so I left them as raw number, now. After I have enough more numbers, I shall consider of their meanings, together, then use macros in one area. > And if you > are going to use opcode_tilegx.h anyway, you get the names "for free". > OK, thanks. I shall use opcode_tilegx.h, and we needn't consider about these raw numbers. That is also one of reason why I am not consider more for these numbers: since the code is before reviewing, if not quite necessary, I will not devote more time resources on coding styles. ;-) Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed