From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQYdp-0002x1-NZ for qemu-devel@nongnu.org; Wed, 25 Feb 2015 04:52:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQYdl-00048B-8u for qemu-devel@nongnu.org; Wed, 25 Feb 2015 04:52:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43515 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQYdl-00047X-2q for qemu-devel@nongnu.org; Wed, 25 Feb 2015 04:52:25 -0500 Message-ID: <54ED9B55.1090001@suse.de> Date: Wed, 25 Feb 2015 10:52:21 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1423242249-101524-1-git-send-email-agraf@suse.de> <1423242249-101524-4-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 3/4] arm: Add PCIe host bridge in virt machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Rob Herring , "Michael S. Tsirkin" , QEMU Developers , Ard Biesheuvel , Claudio Fontana , Alvise Rigo , Stuart Yoder On 24.02.15 16:09, Peter Maydell wrote: > On 7 February 2015 at 02:04, Alexander Graf wrote: >> typedef struct MemMapEntry { >> @@ -129,13 +131,21 @@ static const MemMapEntry a15memmap[] = { >> [VIRT_FW_CFG] = { 0x09020000, 0x0000000a }, >> [VIRT_MMIO] = { 0x0a000000, 0x00000200 }, >> /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */ >> - /* 0x10000000 .. 0x40000000 reserved for PCI */ >> + /* >> + * PCIE verbose map: >> + * >> + * MMIO window { 0x10000000, 0x2eff0000 }, >> + * PIO window { 0x3eff0000, 0x00010000 }, >> + * ECAM { 0x3f000000, 0x01000000 }, > > Is this a typo, or is there really a big gap between the > end of the MMIO window and the start of the PIO window? It's perfectly correct, the map is tuples of { offset, length }: 0000000010000000-000000003efeffff (prio 0, RW): alias pcie-mmio @gpex_mmio 0000000010000000-000000003efeffff 000000003eff0000-000000003effffff (prio 0, RW): gpex_ioport 000000003f000000-000000003fffffff (prio 0, RW): alias pcie-ecam @pcie-mmcfg 0000000000000000-0000000000ffffff Alex