All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 00/12] Testing the Y tiled display
Date: Wed, 25 Feb 2015 10:58:55 +0000	[thread overview]
Message-ID: <54EDAAEF.7010505@linux.intel.com> (raw)
In-Reply-To: <20150224215358.GM24485@phenom.ffwll.local>



On 02/24/2015 09:53 PM, Daniel Vetter wrote:
> On Mon, Feb 23, 2015 at 03:57:43PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Starting with Skylake the display engine can scan out Y tiled objects. (Both
>> legacy Y tiled, and the new Yf format.)
>>
>> This series takes the original work by Damien Lespiau and converts it to use the
>> new frame buffer modifiers instead of object set/get tiling. Some patches needed
>> to be dropped, some added and some refactored.
>>
>> v2: Refactored for fb modifier changes.
>>
>> Damien Lespiau (7):
>>    lib: Extract igt_buf_write_to_png() from gem_render_copy
>>    lib/skl: Add gen9 specific igt_blitter_fast_copy()
>>    lib: Don't give a struct igt_buf * to fast_copy_pitch()
>>    lib: Split two helpers to build fast copy's dword0 and dword1
>>    lib: Provide a raw version of the gen9 fast copy blits
>>    lib: Allow the creation of Ys/Yf tiled FBs
>>    testdisplay/skl: Add command line options for Yb/Yf tiled fbs
>>
>> Tvrtko Ursulin (5):
>>    tests/kms_addfb: Add support for fb modifiers
>>    tests/kms_addfb: Y tiled testcases
>>    tiling: Convert framebuffer helpers to use fb modifiers
>>    lib: Add support for new extension to the ADDFB2 ioctl.
>>    lib/igt_fb: Use new ADDFB2 extension for new tiling modes
>
> Test coverage looks good to me overall, just two minor things:
> - functional automated test (replied to the testdisplay patch)
> - catching invalid modifiers and making sure y/yf tiling is reject

Will add - not sure how I lost this, I am pretty sure it was there 
earlier on.

>    unconditionally on pre-gen9 seem to be missing too.

ksm_addfb tests for rejecting Y tiling pre gen 9.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-02-25 10:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 15:57 [PATCH i-g-t 00/12] Testing the Y tiled display Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 01/12] tests/kms_addfb: Add support for fb modifiers Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 02/12] lib: Extract igt_buf_write_to_png() from gem_render_copy Tvrtko Ursulin
2015-02-24 21:49   ` Daniel Vetter
2015-02-23 15:57 ` [PATCH i-g-t 03/12] tests/kms_addfb: Y tiled testcases Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 04/12] lib/skl: Add gen9 specific igt_blitter_fast_copy() Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 05/12] lib: Don't give a struct igt_buf * to fast_copy_pitch() Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 06/12] lib: Split two helpers to build fast copy's dword0 and dword1 Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 07/12] lib: Provide a raw version of the gen9 fast copy blits Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 08/12] tiling: Convert framebuffer helpers to use fb modifiers Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 09/12] lib: Add support for new extension to the ADDFB2 ioctl Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 10/12] lib/igt_fb: Use new ADDFB2 extension for new tiling modes Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 11/12] lib: Allow the creation of Ys/Yf tiled FBs Tvrtko Ursulin
2015-02-23 15:57 ` [PATCH i-g-t 12/12] testdisplay/skl: Add command line options for Yb/Yf tiled fbs Tvrtko Ursulin
2015-02-24 21:51   ` Daniel Vetter
2015-02-25 10:55     ` Tvrtko Ursulin
2015-02-25 15:05       ` Daniel Vetter
2015-02-24 21:53 ` [PATCH i-g-t 00/12] Testing the Y tiled display Daniel Vetter
2015-02-25 10:58   ` Tvrtko Ursulin [this message]
2015-02-25 17:08 ` [PATCH v5 01/13] tests/kms_addfb: Add support for fb modifiers Tvrtko Ursulin
2015-02-25 21:17   ` Daniel Vetter
2015-02-25 17:27 ` [PATCH v2 02/12] lib: Extract igt_buf_write_to_png() from gem_render_copy Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EDAAEF.7010505@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.