From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH DOCDAY v2] netif.h: describe request/response structures in terms of binary layout Date: Wed, 25 Feb 2015 13:57:02 +0000 Message-ID: <54EDD4AE.1050408@citrix.com> References: <1424871588-28809-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1424871588-28809-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, keir@xen.org, ian.jackson@eu.citrix.com, jbeulich@suse.com, =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= List-Id: xen-devel@lists.xenproject.org On 25/02/15 13:39, Ian Campbell wrote: > > + * Guest transmit > + * ============== > + * > + * Ring slot size is 12 octets, however not all request/response > + * structs use the full size. > + * > + * tx request data (netif_tx_request_t) > + * ------------------------------------ > + * > + * 0 1 2 3 4 5 6 7 octet > + * +-----+-----+-----+-----+-----+-----+-----+-----+ > + * | grant ref | offset | flags | > + * +-----+-----+-----+-----+-----+-----+-----+-----+ > + * | id | size | > + * +-----+-----+-----+-----+ > + * > + * grant ref: Reference to buffer page. > + * offset: Offset within buffer page. > + * flags: NETTXF_*. > + * id: request identifier, echoed in response. > + * size: packet size in bytes. This size field should be described better since it's a bit weird when a packet it split across multiple requests -- I have to look at the implementations every time. David