From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [RFC v1 7/8] xen: unwrap XEN_BACKEND from XEN_DOM0
Date: Wed, 25 Feb 2015 14:30:53 +0000
Message-ID: <54EDDC9D.9060602@citrix.com>
References: <1423720996-3332-1-git-send-email-mcgrof@do-not-panic.com>	<1423720996-3332-8-git-send-email-mcgrof@do-not-panic.com>
	<alpine.DEB.2.02.1502251415460.23507@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1YQd0a-0004xG-Ov
	for xen-devel@lists.xenproject.org; Wed, 25 Feb 2015 14:32:16 +0000
In-Reply-To: <alpine.DEB.2.02.1502251415460.23507@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org, mcgrof@suse.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com
List-Id: xen-devel@lists.xenproject.org

On 25/02/15 14:17, Stefano Stabellini wrote:
> On Wed, 11 Feb 2015, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>>
>> This unwraps XEN_BACKEND from depending on XEN_DOM0, it
>> instead makes it depend on the possible x86 backends and
>> under what scenerios its allowed under ARM. This is as per
>> the agreed upon Xen Kconfig changes [0].
>>
>> [0] http://comments.gmane.org/gmane.comp.emulators.xen.devel/231579
>>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
>> ---
>>  arch/x86/xen/Kconfig | 2 ++
>>  drivers/xen/Kconfig  | 3 ++-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
>> index 50e2fb4..9298eb3 100644
>> --- a/arch/x86/xen/Kconfig
>> +++ b/arch/x86/xen/Kconfig
>> @@ -16,8 +16,10 @@ config XEN
>>  
>>  config XEN_DOM0
>>  	def_bool y
>> +	select XEN_BACKEND
>>  	depends on XEN && PCI_XEN && SWIOTLB_XEN
>>  	depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
>> +	depends on XEN_PV || XEN_PVH
>>  
>>  config XEN_PVHVM
>>  	def_bool y
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index 31391bc..d8bd3f6 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -77,7 +77,8 @@ config XEN_DEV_EVTCHN
>>  
>>  config XEN_BACKEND
>>  	bool "Backend driver support"
>> -	depends on XEN_DOM0
>> +	depends on ARM || ARM64 || (X86 && (XEN_PV || XEN_PVH || XEN_PVHVM))
>> +	select SWIOTLB_XEN if ARM || ARM64
>>  	default y
>>  	help
>>  	  Support for backend device drivers that provide I/O services
> 
> If you do this people could enable XEN_BACKEND without XEN on ARM.
> I think it needs to be:
> 
> depends on (XEN && (ARM || ARM64)) || (X86 && (XEN_PV || XEN_PVH || XEN_PVHVM))

It's this more sufficiently:

depends on XEN ?

David