From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Wed, 25 Feb 2015 14:52:27 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT Message-Id: <54EDE1AB.9020406@roeck-us.net> List-Id: References: <1424696334-14767-1-git-send-email-simon.guinot@sequanux.org> <54EB33D4.1000804@roeck-us.net> <20150223143416.GT1509@kw.sim.vm.gnt> <54EB3C84.30503@roeck-us.net> <20150225111430.GV1509@kw.sim.vm.gnt> <20150225135015.GA17992@lunn.ch> <20150225142924.GX1509@kw.sim.vm.gnt> In-Reply-To: <20150225142924.GX1509@kw.sim.vm.gnt> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 02/25/2015 06:29 AM, Simon Guinot wrote: > On Wed, Feb 25, 2015 at 02:50:15PM +0100, Andrew Lunn wrote: >>> Handle the GPIO fan alarm feature from the fan controller driver don't >>> look good either to me. This alarm mechanism is not a part of the fan >>> controller itself but rather something apart. Also I am afraid that the >>> result would really look like a hack. >> >> Hi Simon >> >> It sounds like you need to extract the alarm code from gpio-fan into a >> little library. Then put a wrapper around it to make a gpio-fan-alarm >> driver. > > Hi Andrew, > > Yes, I am working on that. I'll come back with some patches based on > this approach. > I have not seen your patches, but from the context it sounds like a NACK. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Wed, 25 Feb 2015 06:52:27 -0800 Subject: [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT In-Reply-To: <20150225142924.GX1509@kw.sim.vm.gnt> References: <1424696334-14767-1-git-send-email-simon.guinot@sequanux.org> <54EB33D4.1000804@roeck-us.net> <20150223143416.GT1509@kw.sim.vm.gnt> <54EB3C84.30503@roeck-us.net> <20150225111430.GV1509@kw.sim.vm.gnt> <20150225135015.GA17992@lunn.ch> <20150225142924.GX1509@kw.sim.vm.gnt> Message-ID: <54EDE1AB.9020406@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/25/2015 06:29 AM, Simon Guinot wrote: > On Wed, Feb 25, 2015 at 02:50:15PM +0100, Andrew Lunn wrote: >>> Handle the GPIO fan alarm feature from the fan controller driver don't >>> look good either to me. This alarm mechanism is not a part of the fan >>> controller itself but rather something apart. Also I am afraid that the >>> result would really look like a hack. >> >> Hi Simon >> >> It sounds like you need to extract the alarm code from gpio-fan into a >> little library. Then put a wrapper around it to make a gpio-fan-alarm >> driver. > > Hi Andrew, > > Yes, I am working on that. I'll come back with some patches based on > this approach. > I have not seen your patches, but from the context it sounds like a NACK. Guenter