From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: vdso: minor ABI fix for clock_getres
Date: Wed, 25 Feb 2015 10:14:19 -0600 [thread overview]
Message-ID: <54EDF4DB.5080007@mentor.com> (raw)
In-Reply-To: <20150225160226.GL12377@arm.com>
On 02/25/2015 10:02 AM, Will Deacon wrote:
> On Tue, Feb 24, 2015 at 11:21:07PM +0000, Nathan Lynch wrote:
>> The vdso implementation of clock_getres currently returns 0 (success)
>> whenever a null timespec is provided by the caller, regardless of the
>> clock id supplied.
>>
>> This behavior is incorrect. It should fall back to syscall when an
>> unrecognized clock id is passed, even when the timespec argument is
>> null. This ensures that clock_getres always returns an error for
>> invalid clock ids.
>>
>> Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
>> ---
>> arch/arm64/kernel/vdso/gettimeofday.S | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Thanks, Nathan.
Thank you. I'm curious -- do you know of a use case for the VDSO
implementation of clock_getres? I.e. what kind of real-world workload
sees a benefit from it?
I'm not suggesting removing it from the arm64 vdso, but I'm considering
dropping clock_getres from the 32-bit ARM vdso patch set since I haven't
been able to answer this.
next prev parent reply other threads:[~2015-02-25 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 23:21 [PATCH] arm64: vdso: minor ABI fix for clock_getres Nathan Lynch
2015-02-25 16:02 ` Will Deacon
2015-02-25 16:14 ` Nathan Lynch [this message]
2015-02-25 16:32 ` Will Deacon
2015-02-25 18:33 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDF4DB.5080007@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.