diff for duplicates of <54EE0625.7050604@fr.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 9544808..3880102 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,25 +1,34 @@ -T24gMDIvMjQvMjAxNSAwNTo1NCBBTSwgTWljaGFlbCBFbGxlcm1hbiB3cm90ZToKPiBPbiBGcmks -IDIwMTUtMDItMjAgYXQgMTY6MDcgKzAxMDAsIEPDqWRyaWMgTGUgR29hdGVyIHdyb3RlOgo+PiBT -aWduZWQtb2ZmLWJ5OiBDw6lkcmljIExlIEdvYXRlciA8Y2xnQGZyLmlibS5jb20+Cj4+IC0tLQo+ -PiAgYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwtc2Vuc29yLmMgfCAgICAzICsr -Kwo+PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEv -YXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwtc2Vuc29yLmMgYi9hcmNoL3Bvd2Vy -cGMvcGxhdGZvcm1zL3Bvd2VybnYvb3BhbC1zZW5zb3IuYwo+PiBpbmRleCA0YWI2N2VmN2FiYzku -LjU0NDI5MmYyMDIwZiAxMDA2NDQKPj4gLS0tIGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dl -cm52L29wYWwtc2Vuc29yLmMKPj4gKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52 -L29wYWwtc2Vuc29yLmMKPj4gQEAgLTcyLDYgKzcyLDkgQEAgc3RhdGljIF9faW5pdCBpbnQgb3Bh -bF9zZW5zb3JfaW5pdCh2b2lkKQo+PiAgCXN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXY7Cj4+ -ICAJc3RydWN0IGRldmljZV9ub2RlICpzZW5zb3I7Cj4+ICAKPj4gKwlpZiAoIW9wYWxfY2hlY2tf -dG9rZW4oT1BBTF9TRU5TT1JfUkVBRCkpCj4+ICsJCXJldHVybiAtRU5PREVWOwo+PiArCj4+ICAJ -c2Vuc29yID0gb2ZfZmluZF9ub2RlX2J5X3BhdGgoIi9pYm0sb3BhbC9zZW5zb3JzIik7Cj4+ICAJ -aWYgKCFzZW5zb3IpIHsKPj4gIAkJcHJfZXJyKCJPcGFsIG5vZGUgJ3NlbnNvcnMnIG5vdCBmb3Vu -ZFxuIik7Cj4gCj4gQXJlIHlvdSBhY3R1YWxseSBzZWVpbmcgdGhpcyBpbiBwcmFjdGljZT8KCk5v -LiBOb3QgdGhpcyBvbmUuIEkgaGF2ZSBzZWVuIG90aGVycyB0aG91Z2guIEkgd2lsbCBzZW5kIHlv -dSBwYXRjaGVzLgoKPiBJdCdzIGEgYml0IGFubm95aW5nIHRoYXQgd2UgaGF2ZSB0byBjaGVjayBm -b3IgdGhlIHRva2VuLCBhbmQgdGhlbiBhbHNvIGNoZWNrCj4gdGhlIGRldmljZSB0cmVlLiBJdCB3 -b3VsZCBiZSBuaWNlIGlmIG9uZSBpbXBsaWVkIHRoZSBwcmVzZW5jZSBvZiB0aGUgb3RoZXIuCgpT -aG91bGQgd2UgZXhwb3NlIHRoZSBPUEFMIGNhbGwgdG9rZW4gaW4gdGhlIGRldmljZSB0cmVlID8g -CgpDaGVlcnMsCgpDLiAKIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f -X19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5v -cmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29y -cw= +On 02/24/2015 05:54 AM, Michael Ellerman wrote: +> On Fri, 2015-02-20 at 16:07 +0100, Cédric Le Goater wrote: +>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> +>> --- +>> arch/powerpc/platforms/powernv/opal-sensor.c | 3 +++ +>> 1 file changed, 3 insertions(+) +>> +>> diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c b/arch/powerpc/platforms/powernv/opal-sensor.c +>> index 4ab67ef7abc9..544292f2020f 100644 +>> --- a/arch/powerpc/platforms/powernv/opal-sensor.c +>> +++ b/arch/powerpc/platforms/powernv/opal-sensor.c +>> @@ -72,6 +72,9 @@ static __init int opal_sensor_init(void) +>> struct platform_device *pdev; +>> struct device_node *sensor; +>> +>> + if (!opal_check_token(OPAL_SENSOR_READ)) +>> + return -ENODEV; +>> + +>> sensor = of_find_node_by_path("/ibm,opal/sensors"); +>> if (!sensor) { +>> pr_err("Opal node 'sensors' not found\n"); +> +> Are you actually seeing this in practice? + +No. Not this one. I have seen others though. I will send you patches. + +> It's a bit annoying that we have to check for the token, and then also check +> the device tree. It would be nice if one implied the presence of the other. + +Should we expose the OPAL call token in the device tree ? + +Cheers, + +C. diff --git a/a/content_digest b/N1/content_digest index d4442e2..0ca050f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\01424444857-13805-2-git-send-email-clg@fr.ibm.com\0" "ref\01424753699.2318.8.camel@ellerman.id.au\0" "From\0Cedric Le Goater <clg@fr.ibm.com>\0" - "Subject\0Re: [lm-sensors] [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist\0" - "Date\0Wed, 25 Feb 2015 17:28:05 +0000\0" + "Subject\0Re: [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist\0" + "Date\0Wed, 25 Feb 2015 18:28:05 +0100\0" "To\0Michael Ellerman <mpe@ellerman.id.au>\0" "Cc\0Stewart Smith <stewart@linux.vnet.ibm.com>" lm-sensors@lm-sensors.org @@ -14,30 +14,39 @@ " Jean Delvare <jdelvare@suse.de>\0" "\00:1\0" "b\0" - "T24gMDIvMjQvMjAxNSAwNTo1NCBBTSwgTWljaGFlbCBFbGxlcm1hbiB3cm90ZToKPiBPbiBGcmks\n" - "IDIwMTUtMDItMjAgYXQgMTY6MDcgKzAxMDAsIEPDqWRyaWMgTGUgR29hdGVyIHdyb3RlOgo+PiBT\n" - "aWduZWQtb2ZmLWJ5OiBDw6lkcmljIExlIEdvYXRlciA8Y2xnQGZyLmlibS5jb20+Cj4+IC0tLQo+\n" - "PiAgYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwtc2Vuc29yLmMgfCAgICAzICsr\n" - "Kwo+PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEv\n" - "YXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwtc2Vuc29yLmMgYi9hcmNoL3Bvd2Vy\n" - "cGMvcGxhdGZvcm1zL3Bvd2VybnYvb3BhbC1zZW5zb3IuYwo+PiBpbmRleCA0YWI2N2VmN2FiYzku\n" - "LjU0NDI5MmYyMDIwZiAxMDA2NDQKPj4gLS0tIGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dl\n" - "cm52L29wYWwtc2Vuc29yLmMKPj4gKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52\n" - "L29wYWwtc2Vuc29yLmMKPj4gQEAgLTcyLDYgKzcyLDkgQEAgc3RhdGljIF9faW5pdCBpbnQgb3Bh\n" - "bF9zZW5zb3JfaW5pdCh2b2lkKQo+PiAgCXN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXY7Cj4+\n" - "ICAJc3RydWN0IGRldmljZV9ub2RlICpzZW5zb3I7Cj4+ICAKPj4gKwlpZiAoIW9wYWxfY2hlY2tf\n" - "dG9rZW4oT1BBTF9TRU5TT1JfUkVBRCkpCj4+ICsJCXJldHVybiAtRU5PREVWOwo+PiArCj4+ICAJ\n" - "c2Vuc29yID0gb2ZfZmluZF9ub2RlX2J5X3BhdGgoIi9pYm0sb3BhbC9zZW5zb3JzIik7Cj4+ICAJ\n" - "aWYgKCFzZW5zb3IpIHsKPj4gIAkJcHJfZXJyKCJPcGFsIG5vZGUgJ3NlbnNvcnMnIG5vdCBmb3Vu\n" - "ZFxuIik7Cj4gCj4gQXJlIHlvdSBhY3R1YWxseSBzZWVpbmcgdGhpcyBpbiBwcmFjdGljZT8KCk5v\n" - "LiBOb3QgdGhpcyBvbmUuIEkgaGF2ZSBzZWVuIG90aGVycyB0aG91Z2guIEkgd2lsbCBzZW5kIHlv\n" - "dSBwYXRjaGVzLgoKPiBJdCdzIGEgYml0IGFubm95aW5nIHRoYXQgd2UgaGF2ZSB0byBjaGVjayBm\n" - "b3IgdGhlIHRva2VuLCBhbmQgdGhlbiBhbHNvIGNoZWNrCj4gdGhlIGRldmljZSB0cmVlLiBJdCB3\n" - "b3VsZCBiZSBuaWNlIGlmIG9uZSBpbXBsaWVkIHRoZSBwcmVzZW5jZSBvZiB0aGUgb3RoZXIuCgpT\n" - "aG91bGQgd2UgZXhwb3NlIHRoZSBPUEFMIGNhbGwgdG9rZW4gaW4gdGhlIGRldmljZSB0cmVlID8g\n" - "CgpDaGVlcnMsCgpDLiAKIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f\n" - "X19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5v\n" - "cmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29y\n" - cw= + "On 02/24/2015 05:54 AM, Michael Ellerman wrote:\n" + "> On Fri, 2015-02-20 at 16:07 +0100, C\303\251dric Le Goater wrote:\n" + ">> Signed-off-by: C\303\251dric Le Goater <clg@fr.ibm.com>\n" + ">> ---\n" + ">> arch/powerpc/platforms/powernv/opal-sensor.c | 3 +++\n" + ">> 1 file changed, 3 insertions(+)\n" + ">>\n" + ">> diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c b/arch/powerpc/platforms/powernv/opal-sensor.c\n" + ">> index 4ab67ef7abc9..544292f2020f 100644\n" + ">> --- a/arch/powerpc/platforms/powernv/opal-sensor.c\n" + ">> +++ b/arch/powerpc/platforms/powernv/opal-sensor.c\n" + ">> @@ -72,6 +72,9 @@ static __init int opal_sensor_init(void)\n" + ">> \tstruct platform_device *pdev;\n" + ">> \tstruct device_node *sensor;\n" + ">> \n" + ">> +\tif (!opal_check_token(OPAL_SENSOR_READ))\n" + ">> +\t\treturn -ENODEV;\n" + ">> +\n" + ">> \tsensor = of_find_node_by_path(\"/ibm,opal/sensors\");\n" + ">> \tif (!sensor) {\n" + ">> \t\tpr_err(\"Opal node 'sensors' not found\\n\");\n" + "> \n" + "> Are you actually seeing this in practice?\n" + "\n" + "No. Not this one. I have seen others though. I will send you patches.\n" + "\n" + "> It's a bit annoying that we have to check for the token, and then also check\n" + "> the device tree. It would be nice if one implied the presence of the other.\n" + "\n" + "Should we expose the OPAL call token in the device tree ? \n" + "\n" + "Cheers,\n" + "\n" + C. -e573963e5099f80f23b747de38288ec883093c1265ced87f1ce4e7f749a3d218 +44df51e19ea0ba87555b7eb4c0c759481324d162bfd28fb2fddcb1b4c5a48e2f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.