From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Tyler Hall <tylerwhall@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Subject: Re: [PATCH] thermal: armada: read stable temp on Armada XP
Date: Wed, 25 Feb 2015 19:38:26 +0100 [thread overview]
Message-ID: <54EE16A2.7020804@free-electrons.com> (raw)
In-Reply-To: <54EE11C5.8000307@free-electrons.com>
Hi Ezequiel,
On 25/02/2015 19:17, Ezequiel Garcia wrote:
> On 02/25/2015 02:04 PM, Gregory CLEMENT wrote:
>>>
>>> My conclusions about these registers are based on experimental data. The
>>> documentation is very sparse, but the Thermal Manager Control and Status
>>> Register looks like the preferred register given the way it is laid out in the
>>> public spec.
>>
>> Ezequiel,
>>
>> as you worked on this do you know why we used the Thermal Sensor Status Register
>> instead of the Thermal Manager Control and Status Register ?
>> My first guess is that the giving the name of the registers the 1st one made
>> more sens to use for a thermal sensor.
>>
>
> Actually, we based this driver in the vendor bootloader. The specs weren't
> of much use back then.
>
Thanks for your prompt feedback. So we don't have much more information about
the sensor. :(
I will try to get information from Marvell.
Tyler,
In the meantime could you double check your values? The temperature on my board
seemed broken on my board. If needed I can check on an other board. By the way
on which board/product did you try it?
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2015-02-25 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 22:50 [PATCH] thermal: armada: read stable temp on Armada XP Tyler Hall
2015-02-10 22:50 ` Tyler Hall
2015-02-24 18:36 ` Eduardo Valentin
2015-02-24 18:36 ` Eduardo Valentin
[not found] ` <20150224183616.GD3448-ld4jwAGwUXRveXEdyy5Li2QTnQI6vUnv7KzsFvvc4iU@public.gmane.org>
2015-02-24 19:56 ` Tyler Hall
2015-02-24 19:56 ` Tyler Hall
2015-02-25 16:10 ` Gregory CLEMENT
2015-02-25 18:39 ` Eduardo Valentin
[not found] ` <20150225183901.GD2306-ld4jwAGwUXRveXEdyy5Li2QTnQI6vUnv7KzsFvvc4iU@public.gmane.org>
2015-02-25 19:47 ` Tyler Hall
2015-02-25 19:47 ` Tyler Hall
2015-02-25 22:39 ` Tyler Hall
2015-02-25 17:04 ` Gregory CLEMENT
2015-02-25 18:17 ` Ezequiel Garcia
2015-02-25 18:38 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EE16A2.7020804@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.