From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQk6h-0005fg-Q6 for qemu-devel@nongnu.org; Wed, 25 Feb 2015 17:07:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQk6c-0000SO-S4 for qemu-devel@nongnu.org; Wed, 25 Feb 2015 17:07:03 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38316 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQk6c-0000S6-LV for qemu-devel@nongnu.org; Wed, 25 Feb 2015 17:06:58 -0500 Message-ID: <54EE477F.4000106@suse.de> Date: Wed, 25 Feb 2015 23:06:55 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1424894306-26740-1-git-send-email-ehabkost@redhat.com> <1424894306-26740-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1424894306-26740-5-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 04/11] target-i386: Rename cpu_x86_init() to cpu_x86_init_user() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Peter Maydell , Paolo Bonzini Cc: qemu-devel@nongnu.org Am 25.02.2015 um 20:58 schrieb Eduardo Habkost: > The function is used only for CONFIG_USER, so make its purpose clear. >=20 > Reviewed-by: Paolo Bonzini > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 2 +- > target-i386/cpu.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Please don't. I happily got all architectures aligned that it's at least cpu_something_init, and it only happens to be user-only for x86. It is rather the legacy function that was used in both system and user. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)