From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/6] target-arm: kvm: save/restore mp state Date: Thu, 26 Feb 2015 13:57:52 +0100 Message-ID: <54EF1850.5050002@redhat.com> References: <1424880159-29348-1-git-send-email-alex.bennee@linaro.org> <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3192C46AAB for ; Thu, 26 Feb 2015 07:52:20 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gZrAOUNTIHZ2 for ; Thu, 26 Feb 2015 07:52:18 -0500 (EST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6D02C46AA9 for ; Thu, 26 Feb 2015 07:52:17 -0500 (EST) In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu CgpPbiAyNS8wMi8yMDE1IDE3OjAyLCBBbGV4IEJlbm7DqWUgd3JvdGU6Cj4gKyNpZiBkZWZpbmVk IENPTkZJR19LVk0KPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIC5uYW1lID0gIm1wX3N0YXRl IiwKPiArICAgICAgICAgICAgLnZlcnNpb25faWQgPSAwLAo+ICsgICAgICAgICAgICAuc2l6ZSA9 IHNpemVvZih1aW50MzJfdCksCj4gKyAgICAgICAgICAgIC5pbmZvID0gJnZtc3RhdGVfbXBzdGF0 ZSwKPiArICAgICAgICAgICAgLmZsYWdzID0gVk1TX1NJTkdMRSwKPiArICAgICAgICAgICAgLm9m ZnNldCA9IDAsCj4gKyAgICAgICAgfSwKPiArI2VuZGlmCgpUaGlzIG1ha2VzIFRDRyBtaWdyYXRp b24gc3RhdGUgaW5jb21wYXRpYmxlIGRlcGVuZGluZyBvbiB3aGV0aGVyIFFFTVUKd2FzIGJ1aWx0 IG9uIEFSTSBvciB4ODYuCgpZb3UgY2FuIGluc3RlYWQgYWRkIGEgc3Vic2VjdGlvbiwgYW5kIG1h cmsgaXQgYXMgbmVlZGVkIG9ubHkgaWZmCmt2bV9lbmFibGVkKCkuCgpQYW9sbwoKPiAgICAgICAg ICB7Cj4gICAgICAgICAgICAgIC5uYW1lID0gImNwc3IiLApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0 cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9s aXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: pbonzini@redhat.com (Paolo Bonzini) Date: Thu, 26 Feb 2015 13:57:52 +0100 Subject: [PATCH 1/6] target-arm: kvm: save/restore mp state In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> References: <1424880159-29348-1-git-send-email-alex.bennee@linaro.org> <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> Message-ID: <54EF1850.5050002@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25/02/2015 17:02, Alex Benn?e wrote: > +#if defined CONFIG_KVM > + { > + .name = "mp_state", > + .version_id = 0, > + .size = sizeof(uint32_t), > + .info = &vmstate_mpstate, > + .flags = VMS_SINGLE, > + .offset = 0, > + }, > +#endif This makes TCG migration state incompatible depending on whether QEMU was built on ARM or x86. You can instead add a subsection, and mark it as needed only iff kvm_enabled(). Paolo > { > .name = "cpsr", From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQy1R-0007pf-56 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQy1N-0004wI-FK for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQy1N-0004vp-96 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:29 -0500 Message-ID: <54EF1850.5050002@redhat.com> Date: Thu, 26 Feb 2015 13:57:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1424880159-29348-1-git-send-email-alex.bennee@linaro.org> <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/6] target-arm: kvm: save/restore mp state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , qemu-devel@nongnu.org Cc: Peter Maydell , kvm@vger.kernel.org, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org On 25/02/2015 17:02, Alex Benn=C3=A9e wrote: > +#if defined CONFIG_KVM > + { > + .name =3D "mp_state", > + .version_id =3D 0, > + .size =3D sizeof(uint32_t), > + .info =3D &vmstate_mpstate, > + .flags =3D VMS_SINGLE, > + .offset =3D 0, > + }, > +#endif This makes TCG migration state incompatible depending on whether QEMU was built on ARM or x86. You can instead add a subsection, and mark it as needed only iff kvm_enabled(). Paolo > { > .name =3D "cpsr",