From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH v2] RFC: Automatically check xen's public
 headers for C++ pitfalls.
Date: Thu, 26 Feb 2015 19:49:22 +0200
Message-ID: <54EF5CA2.8050807@bitdefender.com>
References: <1424956264-15271-1-git-send-email-tim@xen.org>	<1424967096-6105-1-git-send-email-tim@xen.org>	<20150226162842.GG43832@deinos.phlegethon.org>	<54EF5C3302000078000643ED@mail.emea.novell.com>
	<20150226170154.GB43834@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150226170154.GB43834@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 02/26/2015 07:01 PM, Tim Deegan wrote:
> +#ifdef __cplusplus
> +/* 'private' is a keyword in C++, so we have to use a different name for
> + * private state there.  Leaving the C name alone to avoid unnecessary
> + * pain for the existing users. */
> +#define XEN_RING_PRIVATE pvt
> +#else
> +#define XEN_RING_PRIVATE private
> +#endif

Are there likely to be many users outside of the ones using that code
with mem_event? Because if there aren't, there are much more drastic
changes happening in Tamas' pending series, so perhaps seen that way the
change becomes more acceptable.


Thanks,
Razvan