All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH V6 1/3] MIPS: Rearrange PTE bits into fixed positions.
Date: Thu, 26 Feb 2015 12:04:10 -0800	[thread overview]
Message-ID: <54EF7C3A.3030202@gmail.com> (raw)
In-Reply-To: <1424977294-49507-2-git-send-email-Steven.Hill@imgtec.com>

On 02/26/2015 11:01 AM, Steven J. Hill wrote:
> From: "Steven J. Hill" <Steven.Hill@imgtec.com>
>
> This patch rearranges the PTE bits into fixed positions for R2
> and later cores. In the past, the TLB handling code did runtime
> checking of RI/XI and adjusted the shifts and rotates in order
> to fit the largest PFN value into the PTE. The checking now
> occurs when building the TLB handler, thus eliminating those
> checks. These new arrangements also define the largest possible
> PFN value that can fit in the PTE. HUGE page support is only
> available on 64-bit platforms.
>
> The new layouts of the PTE bits are the following:
>
>     64-bit, R1 or earlier:     CCC D V G [S H] M A W R P
>     32-bit, R1 or earler:      CCC D V G M A W R P
>     64-bit, R2 or later:       CCC D V G RI XI [S H] M A W R P
>     32-bit, R2 or later:       CCC D V G RI XI M A W R P
>
> In the case of cores that support the RI/XI bits, the value of
> the R bit is ignored.
>

Why not just use RI for everything, instead of taking up two bits to 
represent a single binary concept?

For the case where there is no RI hardware active, it is a purely 
software bit and you can easily invert the meaning and just have a 
_PAGE_NO_READ bit.

Also how does this change interact with __swp_type/_swp_offset/__swp_entry?

David Daney

  reply	other threads:[~2015-02-26 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 19:01 [PATCH V6 0/3] Add support for eXtended Physical Addressing Steven J. Hill
2015-02-26 19:01 ` [PATCH V6 1/3] MIPS: Rearrange PTE bits into fixed positions Steven J. Hill
2015-02-26 20:04   ` David Daney [this message]
2015-02-26 19:01 ` [PATCH V6 2/3] MIPS: Add support for XPA Steven J. Hill
2015-02-26 19:01 ` [PATCH V6 3/3] MIPS: XPA: Add new configuration file Steven J. Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF7C3A.3030202@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=Steven.Hill@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.