Re: [Qemu-devel] [PATCH] hmp: info spice: Show string channel name

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On 02/26/2015 12:02 PM, Cole Robinson wrote:
> Useful for debugging.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=822418
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  hmp.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/hmp.c b/hmp.c
> index 735097c..93fd5cd 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -545,6 +545,11 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
>  {
>      SpiceChannelList *chan;
>      SpiceInfo *info;
> +    const char *channel_name;
> +    /* String representations of SPICE_CHANNEL_* enum */
> +    const char * const channel_names[] = {"main", "display", "input", "cursor",
> +        "playback", "record", "tunnel", "smartcard", "usbredir", "port",
> +        "webdav"};
>  

Hmm. I wonder if we should have a QAPI enum for this, instead of
open-coding it here.  But as this is already a strict improvement,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]