[PATCH] strverscmp.3: Add FIXME

[PATCH] strverscmp.3: Add FIXME

[Ma Shimiao]

Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/strverscmp.3 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man3/strverscmp.3 b/man3/strverscmp.3
index 241065d..ec6449f 100644
--- a/man3/strverscmp.3
+++ b/man3/strverscmp.3
@@ -97,6 +97,13 @@ l l l.
 Interface	Attribute	Value
 T{
 .BR strverscmp ()
+.\" FIXME: the following marking is different from which in glibc manual.
+.\" strverscmp: MT-Safe locale
+.\" glibc manual says strverscmp should have marking locale because it calls
+.\" isdigit() multiple times and isdigit() uses locale variable.
+.\" But isdigit() has two implementations. With different compiling conditions,
+.\" we may call isdigit() in macro, then strverscmp() should not have locale
+.\" problem.
 T}	Thread safety	MT-Safe
 .TE
 .SH CONFORMING TO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] strverscmp.3: Add FIXME

[Michael Kerrisk (man-pages)]

On 02/27/2015 03:01 AM, Ma Shimiao wrote:
> Signed-off-by: Ma Shimiao <mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
T
hank you, Ma Shimiao. Applied.

Cheers,

Michael

> ---
>  man3/strverscmp.3 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/man3/strverscmp.3 b/man3/strverscmp.3
> index 241065d..ec6449f 100644
> --- a/man3/strverscmp.3
> +++ b/man3/strverscmp.3
> @@ -97,6 +97,13 @@ l l l.
>  Interface	Attribute	Value
>  T{
>  .BR strverscmp ()
> +.\" FIXME: the following marking is different from which in glibc manual.
> +.\" strverscmp: MT-Safe locale
> +.\" glibc manual says strverscmp should have marking locale because it calls
> +.\" isdigit() multiple times and isdigit() uses locale variable.
> +.\" But isdigit() has two implementations. With different compiling conditions,
> +.\" we may call isdigit() in macro, then strverscmp() should not have locale
> +.\" problem.
>  T}	Thread safety	MT-Safe
>  .TE
>  .SH CONFORMING TO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html