From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?U8OpYmFzdGllbiBTWllNQU5TS0k=?= Subject: Bug in i2c-core? Date: Fri, 27 Feb 2015 12:09:51 +0100 Message-ID: <54F0507F.6030804@armadeus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "linux-arm-kernel@lists.infradead.org" , Dmitry Torokhov , Wolfram Sang , laurent.pinchart+renesas@ideasonboard.com, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org SGksCgpJIGFtIHdyaXRpbmcgYW4gSTJDIHRvdWNoc2NyZWVuIGRyaXZlciBmb3IgYW4gaS5NWDYg YmFzZWQgYm9hcmQuIEkKY29tcGlsZWQgaXQgYXMgYSBtb2R1bGUgYW5kIHdoZW4gSSB1bmxvYWQg aXQsIEkgZ2V0IHRoZSBmb2xsb3dpbmcgd2FybmluZzoKCiMgbW9kcHJvYmUgc3g4NjU0ClsgICA0 Ni4yNjE0OTRdIGlucHV0OiBTWDg2NTQgSTJDIFRvdWNoc2NyZWVuIGFzCi9kZXZpY2VzL3NvYzAv c29jLzIxMDAwMDAuYWlwcy1idXMvMjFhMDAwMC5pMmMvaTJjLTAvMC0wMDQ4L2lucHV0L2lucHV0 MQojIHJtbW9kIHN4ODY1NApbICAgNzYuNDM1MjIzXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0t LS0tLS0tLS0tLS0KWyAgIDc2LjQzOTkwOV0gV0FSTklORzogQ1BVOiAwIFBJRDogMTM0IGF0IGZz L3Byb2MvZ2VuZXJpYy5jOjU1MgpyZW1vdmVfcHJvY19lbnRyeSsweDE0OC8weDE2NCgpClsgICA3 Ni40NDg1ODJdIHJlbW92ZV9wcm9jX2VudHJ5OiByZW1vdmluZyBub24tZW1wdHkgZGlyZWN0b3J5 CidpcnEvMjA4JywgbGVha2luZyBhdCBsZWFzdCAnc3g4NjU0JwpbICAgNzYuNDU3NDQ1XSBNb2R1 bGVzIGxpbmtlZCBpbjogc3g4NjU0KC0pClsgICA3Ni40NjE0NTJdIENQVTogMCBQSUQ6IDEzNCBD b21tOiBybW1vZCBOb3QgdGFpbnRlZAo0LjAuMC1yYzEtMDAwMDItZzMwZjk1YWItZGlydHkgIzYK WyAgIDc2LjQ2OTM4MF0gSGFyZHdhcmUgbmFtZTogRnJlZXNjYWxlIGkuTVg2IFF1YWQvRHVhbExp dGUgKERldmljZSBUcmVlKQpbICAgNzYuNDc1OTc3XSBCYWNrdHJhY2U6ClsgICA3Ni40Nzg1MDRd IFs8ODAwMTI2Mzg+XSAoZHVtcF9iYWNrdHJhY2UpIGZyb20gWzw4MDAxMjg1ND5dCihzaG93X3N0 YWNrKzB4MTgvMHgxYykKWyAgIDc2LjQ4NjE2NF0gIHI3OjgwMTUxZTA0IHI2OjgwOWRkNGIwIHI1 OjAwMDAwMDAwIHI0OjAwMDAwMDAwClsgICA3Ni40OTE5OTBdIFs8ODAwMTI4M2M+XSAoc2hvd19z dGFjaykgZnJvbSBbPDgwNmVhNmNjPl0KKGR1bXBfc3RhY2srMHg4Yy8weGE0KQpbICAgNzYuNDk5 MzQwXSBbPDgwNmVhNjQwPl0gKGR1bXBfc3RhY2spIGZyb20gWzw4MDAyYWRkND5dCih3YXJuX3Ns b3dwYXRoX2NvbW1vbisweDdjLzB4YjgpClsgICA3Ni41MDc1MDldICByNzo4MDE1MWUwNCByNjow MDAwMDIyOCByNTowMDAwMDAwOSByNDpiZGFjYmRiOApbICAgNzYuNTEzMzExXSBbPDgwMDJhZDU4 Pl0gKHdhcm5fc2xvd3BhdGhfY29tbW9uKSBmcm9tIFs8ODAwMmFlNDg+XQood2Fybl9zbG93cGF0 aF9mbXQrMHgzOC8weDQwKQpbICAgNzYuNTIyMTEwXSAgcjg6ODAwMGVlMDQgcjc6ODA5ZDEzNjAg cjY6YmUwMzhlODAgcjU6YmUwMzhlZjUgcjQ6ODA4OThhMTgKWyAgIDc2LjUyOTAyN10gWzw4MDAy YWUxND5dICh3YXJuX3Nsb3dwYXRoX2ZtdCkgZnJvbSBbPDgwMTUxZTA0Pl0KKHJlbW92ZV9wcm9j X2VudHJ5KzB4MTQ4LzB4MTY0KQpbICAgNzYuNTM3NzI4XSAgcjM6ODA2ZmE4MDAgcjI6ODA4OThh MTgKWyAgIDc2LjU0MTM4NV0gIHI0OmJkYTAxZTgwClsgICA3Ni41NDM5ODNdIFs8ODAxNTFjYmM+ XSAocmVtb3ZlX3Byb2NfZW50cnkpIGZyb20gWzw4MDA3NjM5MD5dCih1bnJlZ2lzdGVyX2lycV9w cm9jKzB4OTQvMHhiOCkKWyAgIDc2LjU1MjcxNV0gIHI2OjAwMDAwMGQwIHI1OjgxMjBlZGI4IHI0 OmJlMGMxMTAwClsgICA3Ni41NTc0ODVdIFs8ODAwNzYyZmM+XSAodW5yZWdpc3Rlcl9pcnFfcHJv YykgZnJvbSBbPDgwMDZlZTUwPl0KKGZyZWVfZGVzYysweDM0LzB4NmMpClsgICA3Ni41NjU0NTBd ICByNjowMDAwMDBkMCByNTo4MDlkMTM1NCByNDpiZTBjMTEwMApbICAgNzYuNTcwMTI3XSBbPDgw MDZlZTFjPl0gKGZyZWVfZGVzYykgZnJvbSBbPDgwMDZlZWQwPl0KKGlycV9mcmVlX2Rlc2NzKzB4 NDgvMHg4NCkKWyAgIDc2LjU3NzYzNl0gIHI3OjAwMDAwMDAxIHI2OjAwMDAwMGQwIHI1OjAwMDAw MGQxIHI0OjAwMDAwMGQxClsgICA3Ni41ODMzODNdIFs8ODAwNmVlODg+XSAoaXJxX2ZyZWVfZGVz Y3MpIGZyb20gWzw4MDA3NTMwOD5dCihpcnFfZGlzcG9zZV9tYXBwaW5nKzB4NDAvMHg1YykKWyAg IDc2LjU5MTc2MV0gIHI3OjAwMDAwMDgxIHI2OmJlMWNiNDU0IHI1OmJlMWNiNDIwIHI0OjAwMDAw MGQwClsgICA3Ni41OTc1MTldIFs8ODAwNzUyYzg+XSAoaXJxX2Rpc3Bvc2VfbWFwcGluZykgZnJv bSBbPDgwNGIxOGI0Pl0KKGkyY19kZXZpY2VfcmVtb3ZlKzB4NjgvMHg4OCkKWyAgIDc2LjYwNjE3 OF0gIHI1OmJlMWNiNDIwIHI0OjAwMDAwMDAwClsgICA3Ni42MDk4MDZdIFs8ODA0YjE4NGM+XSAo aTJjX2RldmljZV9yZW1vdmUpIGZyb20gWzw4MDM5ZWNmMD5dCihfX2RldmljZV9yZWxlYXNlX2Ry aXZlcisweDc4LzB4Y2MpClsgICA3Ni42MTg4MTBdICByNTo3ZjAwMDc4NCByNDpiZTFjYjQyMApb ICAgNzYuNjIyNDMyXSBbPDgwMzllYzc4Pl0gKF9fZGV2aWNlX3JlbGVhc2VfZHJpdmVyKSBmcm9t IFs8ODAzOWY0Njg+XQooZHJpdmVyX2RldGFjaCsweGJjLzB4YzApClsgICA3Ni42MzEwNjhdICBy NTo3ZjAwMDc4NCByNDpiZTFjYjQyMApbICAgNzYuNjM0NzIwXSBbPDgwMzlmM2FjPl0gKGRyaXZl cl9kZXRhY2gpIGZyb20gWzw4MDM5ZWExOD5dCihidXNfcmVtb3ZlX2RyaXZlcisweDU0LzB4YTgp ClsgICA3Ni42NDI4MTRdICByNzowMDAwMDA4MSByNjowMDAwMzQzNSByNTo3ZWU2OGE3OCByNDo3 ZjAwMDc4NApbICAgNzYuNjQ4NTcwXSBbPDgwMzllOWM0Pl0gKGJ1c19yZW1vdmVfZHJpdmVyKSBm cm9tIFs8ODAzOWZhYzg+XQooZHJpdmVyX3VucmVnaXN0ZXIrMHgzMC8weDUwKQpbICAgNzYuNjU3 MDU2XSAgcjU6N2VlNjhhNzggcjQ6N2YwMDA3ODQKWyAgIDc2LjY2MDY3OV0gWzw4MDM5ZmE5OD5d IChkcml2ZXJfdW5yZWdpc3RlcikgZnJvbSBbPDgwNGIyYWEwPl0KKGkyY19kZWxfZHJpdmVyKzB4 MjAvMHgyOCkKWyAgIDc2LjY2ODg5M10gIHI1OjdlZTY4YTc4IHI0OjdmMDAwNzY4ClsgICA3Ni42 NzI1MjJdIFs8ODA0YjJhODA+XSAoaTJjX2RlbF9kcml2ZXIpIGZyb20gWzw3ZjAwMDQ0OD5dCihz eDg2NTRfZHJpdmVyX2V4aXQrMHgxNC8weDFjIFtzeDg2NTRdKQpbICAgNzYuNjgxNTkzXSAgcjU6 N2VlNjhhNzggcjQ6N2YwMDA3ZDQKWyAgIDc2LjY4NTI1N10gWzw3ZjAwMDQzND5dIChzeDg2NTRf ZHJpdmVyX2V4aXQgW3N4ODY1NF0pIGZyb20KWzw4MDA5NjdlOD5dIChTeVNfZGVsZXRlX21vZHVs ZSsweDEyMC8weDFjNCkKWyAgIDc2LjY5NDc3M10gWzw4MDA5NjZjOD5dIChTeVNfZGVsZXRlX21v ZHVsZSkgZnJvbSBbPDgwMDBlYzQwPl0KKHJldF9mYXN0X3N5c2NhbGwrMHgwLzB4NGMpClsgICA3 Ni43MDMwNThdICByNTozNjM4Nzg3MyByNDowMDAyNTAxNApbICAgNzYuNzA2NjkxXSAtLS1bIGVu ZCB0cmFjZSBjOTJhM2UwM2IxYzYzYWJjIF0tLS0KCgpNeSBkcml2ZXIgaXMgc2ltaWxhciB0byBv dGhlciB0b3VjaHNjcmVlbiBkcml2ZXJzLCBpLmUuIGFyMTAyMV9pMmMuYy4KCgovKgogKiBkcml2 ZXJzL2lucHV0L3RvdWNoc2NyZWVuL3N4ODY1NC5jCiAqCiAqIENvcHlyaWdodCAoYykgMjAxNSBB cm1hZGV1cyBTeXN0ZW1zCiAqICAgICAgU8OpYmFzdGllbiBTenltYW5za2kgPHNlYmFzdGllbi5z enltYW5za2lAYXJtYWRldXMuY29tPgogKgogKiBVc2luZyBjb2RlIGZyb206CiAqICAtIHN4ODY1 eC5jCiAqICAgICAgQ29weXJpZ2h0IChjKSAyMDEzIFUtTW9CbyBTcmwKICogICAgICBQaWVybHVp Z2kgUGFzc2FybyA8cC5wYXNzYXJvQHUtbW9iby5jb20+CiAqICAtIHN4ODY1MC5jCiAqICAgICAg Q29weXJpZ2h0IChjKSAyMDA5IFdheW5lIFJvYmVydHMKICogIC0gdHNjMjAwNy5jCiAqICAgICAg Q29weXJpZ2h0IChjKSAyMDA4IEt3YW5nd29vIExlZQogKiAgLSBhZHM3ODQ2LmMKICogICAgICBD b3B5cmlnaHQgKGMpIDIwMDUgRGF2aWQgQnJvd25lbGwKICogICAgICBDb3B5cmlnaHQgKGMpIDIw MDYgTm9raWEgQ29ycG9yYXRpb24KICogIC0gY29yZ2lfdHMuYwogKiAgICAgIENvcHlyaWdodCAo QykgMjAwNC0yMDA1IFJpY2hhcmQgUHVyZGllCiAqICAtIG9tYXBfdHMuW2hjXSwgYWRzNzg0Ni5o LCB0c19vc2suYwogKiAgICAgIENvcHlyaWdodCAoQykgMjAwMiBNb250YVZpc3RhIFNvZnR3YXJl CiAqICAgICAgQ29weXJpZ2h0IChDKSAyMDA0IFRleGFzIEluc3RydW1lbnRzCiAqICAgICAgQ29w eXJpZ2h0IChDKSAyMDA1IERpcmsgQmVobWUKICoKICogIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNv ZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CiAqICBpdCB1bmRl ciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMiBh cwogKiAgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24uCiAqLwoKI2lu Y2x1ZGUgPGxpbnV4L21vZHVsZS5oPgojaW5jbHVkZSA8bGludXgvaW5wdXQuaD4KI2luY2x1ZGUg PGxpbnV4L29mLmg+CiNpbmNsdWRlIDxsaW51eC9pMmMuaD4KI2luY2x1ZGUgPGxpbnV4L2lycS5o PgojaW5jbHVkZSA8bGludXgvaW50ZXJydXB0Lmg+CgovKiByZWdpc3RlciBhZGRyZXNzZXMgKi8K I2RlZmluZSBJMkNfUkVHX1RPVUNIMCAgICAgICAgICAgICAgICAgIDB4MDAKI2RlZmluZSBJMkNf UkVHX1RPVUNIMSAgICAgICAgICAgICAgICAgIDB4MDEKI2RlZmluZSBJMkNfUkVHX0NIQU5NQVNL ICAgICAgICAgICAgICAgIDB4MDQKI2RlZmluZSBJMkNfUkVHX0lSUU1BU0sgICAgICAgICAgICAg ICAgIDB4MjIKI2RlZmluZSBJMkNfUkVHX0lSUVNSQyAgICAgICAgICAgICAgICAgIDB4MjMKI2Rl ZmluZSBJMkNfUkVHX1NPRlRSRVNFVCAgICAgICAgICAgICAgIDB4M2YKCi8qIGNvbW1hbmRzICov CiNkZWZpbmUgQ01EX1JFQURfUkVHSVNURVIgICAgICAgICAgICAgICAweDQwCiNkZWZpbmUgQ01E X01BTlVBTCAgICAgICAgICAgICAgICAgICAgICAweGMwCiNkZWZpbmUgQ01EX1BFTlRSRyAgICAg ICAgICAgICAgICAgICAgICAweGUwCgovKiB2YWx1ZSBmb3IgSTJDX1JFR19TT0ZUUkVTRVQgKi8K I2RlZmluZSBTT0ZUUkVTRVRfVkFMVUUgICAgICAgICAgICAgICAgIDB4ZGUKCi8qIGJpdHMgZm9y IEkyQ19SRUdfSVJRU1JDICovCiNkZWZpbmUgSVJRX1BFTlRPVUNIX1RPVUNIQ09OVkRPTkUgICAg ICAweDA4CiNkZWZpbmUgSVJRX1BFTlJFTEVBU0UgICAgICAgICAgICAgICAgICAweDA0CgovKiBi aXRzIGZvciBSZWdUb3VjaDEgKi8KI2RlZmluZSBDT05ESVJRICAgICAgICAgICAgICAgICAgICAg ICAgIDB4MjAKI2RlZmluZSBGSUxUXzdTQSAgICAgICAgICAgICAgICAgICAgICAgIDB4MDMKCi8q IGJpdHMgZm9yIEkyQ19SRUdfQ0hBTk1BU0sgKi8KI2RlZmluZSBDT05WX1ggICAgICAgICAgICAg ICAgICAgICAgICAgIDB4ODAKI2RlZmluZSBDT05WX1kgICAgICAgICAgICAgICAgICAgICAgICAg IDB4NDAKCi8qIGNvb3JkaW5hdGVzIHJhdGU6IGhpZ2hlciBuaWJibGUgb2YgQ1RSTDAgcmVnaXN0 ZXIgKi8KI2RlZmluZSBSQVRFX01BTlVBTCAgICAgICAgICAgICAgICAgICAgIDB4MDAKI2RlZmlu ZSBSQVRFXzUwMDBDUFMgICAgICAgICAgICAgICAgICAgIDB4ZjAKCi8qIHBvd2VyIGRlbGF5OiBs b3dlciBuaWJibGUgb2YgQ1RSTDAgcmVnaXN0ZXIgKi8KI2RlZmluZSBQT1dETFlfSU1NRURJQVRF ICAgICAgICAgICAgICAgIDB4MDAKI2RlZmluZSBQT1dETFlfMV8xTVMgICAgICAgICAgICAgICAg ICAgIDB4MGIKCiNkZWZpbmUgTUFYXzEyQklUICAgICAgICAgICAgICAgICAgICAgICAoKDEgPDwg MTIpIC0gMSkKCnN0cnVjdCBzeDg2NTQgewogICAgICAgIHN0cnVjdCBpbnB1dF9kZXYgKmlucHV0 OwogICAgICAgIHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQ7Cn07CgpzdGF0aWMgaXJxcmV0dXJu X3Qgc3g4NjU0X2lycShpbnQgaXJxLCB2b2lkICpoYW5kbGUpCnsKICAgICAgICBzdHJ1Y3Qgc3g4 NjU0ICpzeDg2NTQgPSBoYW5kbGU7CiAgICAgICAgdTggaXJxc3JjOwogICAgICAgIHU4IGRhdGFb NF07CiAgICAgICAgdW5zaWduZWQgaW50IHgsIHk7CiAgICAgICAgaW50IHJldHZhbDsKCiAgICAg ICAgaXJxc3JjID0gaTJjX3NtYnVzX3JlYWRfYnl0ZV9kYXRhKHN4ODY1NC0+Y2xpZW50LAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoQ01EX1JFQURfUkVHSVNURVIg fApJMkNfUkVHX0lSUVNSQykpOwogICAgICAgIGRldl9kYmcoJnN4ODY1NC0+Y2xpZW50LT5kZXYs ICJpcnFzcmMgPSAweCV4IiwgaXJxc3JjKTsKCiAgICAgICAgaWYgKGlycXNyYyA8IDApCiAgICAg ICAgICAgICAgICBnb3RvIG91dDsKCiAgICAgICAgaWYgKGlycXNyYyAmIElSUV9QRU5SRUxFQVNF KSB7CiAgICAgICAgICAgICAgICBkZXZfZGJnKCZzeDg2NTQtPmNsaWVudC0+ZGV2LCAicGVuIHJl bGVhc2UgaW50ZXJydXB0Iik7CgogICAgICAgICAgICAgICAgaW5wdXRfcmVwb3J0X2tleShzeDg2 NTQtPmlucHV0LCBCVE5fVE9VQ0gsIDApOwogICAgICAgICAgICAgICAgaW5wdXRfc3luYyhzeDg2 NTQtPmlucHV0KTsKICAgICAgICB9CgogICAgICAgIGlmIChpcnFzcmMgJiBJUlFfUEVOVE9VQ0hf VE9VQ0hDT05WRE9ORSkgewogICAgICAgICAgICAgICAgZGV2X2RiZygmc3g4NjU0LT5jbGllbnQt PmRldiwgInBlbiB0b3VjaCBpbnRlcnJ1cHQiKTsKCiAgICAgICAgICAgICAgICByZXR2YWwgPSBp MmNfbWFzdGVyX3JlY3Yoc3g4NjU0LT5jbGllbnQsIGRhdGEsCnNpemVvZihkYXRhKSk7CiAgICAg ICAgICAgICAgICBpZiAocmV0dmFsICE9IHNpemVvZihkYXRhKSkKICAgICAgICAgICAgICAgICAg ICAgICAgZ290byBvdXQ7CgogICAgICAgICAgICAgICAgLyogaW52YWxpZCBkYXRhICovCiAgICAg ICAgICAgICAgICBpZiAodW5saWtlbHkoZGF0YVswXSAmIDB4ODAgfHwgZGF0YVsyXSAmIDB4ODAp KQogICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKCiAgICAgICAgICAgICAgICB4ID0g KChkYXRhWzBdICYgMHhmKSA8PCA4KSB8IChkYXRhWzFdKTsKICAgICAgICAgICAgICAgIHkgPSAo KGRhdGFbMl0gJiAweGYpIDw8IDgpIHwgKGRhdGFbM10pOwoKICAgICAgICAgICAgICAgIGlucHV0 X3JlcG9ydF9hYnMoc3g4NjU0LT5pbnB1dCwgQUJTX1gsIHgpOwogICAgICAgICAgICAgICAgaW5w dXRfcmVwb3J0X2FicyhzeDg2NTQtPmlucHV0LCBBQlNfWSwgeSk7CiAgICAgICAgICAgICAgICBp bnB1dF9yZXBvcnRfa2V5KHN4ODY1NC0+aW5wdXQsIEJUTl9UT1VDSCwgMSk7CiAgICAgICAgICAg ICAgICBpbnB1dF9zeW5jKHN4ODY1NC0+aW5wdXQpOwoKICAgICAgICAgICAgICAgIGRldl9kYmco JnN4ODY1NC0+Y2xpZW50LT5kZXYsICJwb2ludCglNGQsJTRkKVxuIiwgeCwgeSk7CiAgICAgICAg fQoKb3V0OgogICAgICAgIHJldHVybiBJUlFfSEFORExFRDsKfQoKc3RhdGljIGludCBzeDg2NTRf b3BlbihzdHJ1Y3QgaW5wdXRfZGV2ICpkZXYpCnsKICAgICAgICBzdHJ1Y3Qgc3g4NjU0ICpzeDg2 NTQgPSBpbnB1dF9nZXRfZHJ2ZGF0YShkZXYpOwogICAgICAgIHN0cnVjdCBpMmNfY2xpZW50ICpj bGllbnQgPSBzeDg2NTQtPmNsaWVudDsKICAgICAgICBpbnQgZXJyb3I7CgogICAgICAgIC8qIGVu YWJsZSBwZW4gdHJpZ2dlciBtb2RlICovCiAgICAgICAgZXJyb3IgPSBpMmNfc21idXNfd3JpdGVf Ynl0ZV9kYXRhKGNsaWVudCwgSTJDX1JFR19UT1VDSDAsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChSQVRFXzUwMDBDUFMgfCBQT1dETFlfMV8xTVMpKTsKICAgICAg ICBpZiAoZXJyb3IgPCAwKSB7CiAgICAgICAgICAgICAgICBkZXZfZXJyKCZjbGllbnQtPmRldiwg IndyaXRpbmcgdG8gSTJDX1JFR19UT1VDSDAgZmFpbGVkIik7CiAgICAgICAgICAgICAgICByZXR1 cm4gLUVJTzsKICAgICAgICB9CgogICAgICAgIGVycm9yID0gaTJjX3NtYnVzX3dyaXRlX2J5dGUo Y2xpZW50LCBDTURfUEVOVFJHKTsKICAgICAgICBpZiAoZXJyb3IgPCAwKSB7CiAgICAgICAgICAg ICAgICBkZXZfZXJyKCZjbGllbnQtPmRldiwgIndyaXRpbmcgY29tbWFuZCBDTURfUEVOVFJHIGZh aWxlZCIpOwogICAgICAgICAgICAgICAgcmV0dXJuIC1FSU87CiAgICAgICAgfQoKICAgICAgICBl bmFibGVfaXJxKGNsaWVudC0+aXJxKTsKCiAgICAgICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyB2b2lk IHN4ODY1NF9jbG9zZShzdHJ1Y3QgaW5wdXRfZGV2ICpkZXYpCnsKICAgICAgICBzdHJ1Y3Qgc3g4 NjU0ICpzeDg2NTQgPSBpbnB1dF9nZXRfZHJ2ZGF0YShkZXYpOwogICAgICAgIHN0cnVjdCBpMmNf Y2xpZW50ICpjbGllbnQgPSBzeDg2NTQtPmNsaWVudDsKICAgICAgICBpbnQgZXJyb3I7CgogICAg ICAgIGRpc2FibGVfaXJxKGNsaWVudC0+aXJxKTsKCiAgICAgICAgLyogZW5hYmxlIG1hbnVhbCBt b2RlIG1vZGUgKi8KICAgICAgICBlcnJvciA9IGkyY19zbWJ1c193cml0ZV9ieXRlKGNsaWVudCwg Q01EX01BTlVBTCk7CiAgICAgICAgaWYgKGVycm9yIDwgMCkgewogICAgICAgICAgICAgICAgZGV2 X2VycigmY2xpZW50LT5kZXYsICJ3cml0aW5nIGNvbW1hbmQgQ01EX01BTlVBTCBmYWlsZWQiKTsK ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICB9CgogICAgICAgIGVycm9yID0gaTJjX3Nt YnVzX3dyaXRlX2J5dGVfZGF0YShjbGllbnQsIEkyQ19SRUdfVE9VQ0gwLCAwKTsKICAgICAgICBp ZiAoZXJyb3IgPCAwKSB7CiAgICAgICAgICAgICAgICBkZXZfZXJyKCZjbGllbnQtPmRldiwgIndy aXRpbmcgdG8gSTJDX1JFR19UT1VDSDAgZmFpbGVkIik7CiAgICAgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgfQp9CgpzdGF0aWMgaW50IHN4ODY1NF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAq Y2xpZW50LAogICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9p ZCAqaWQpCnsKICAgICAgICBzdHJ1Y3Qgc3g4NjU0ICpzeDg2NTQ7CiAgICAgICAgc3RydWN0IGlu cHV0X2RldiAqaW5wdXQ7CiAgICAgICAgaW50IGVycm9yOwoKICAgICAgICBpZiAoIWkyY19jaGVj a19mdW5jdGlvbmFsaXR5KGNsaWVudC0+YWRhcHRlciwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIEkyQ19GVU5DX1NNQlVTX1JFQURfV09SRF9EQVRBKSkKICAgICAgICAgICAg ICAgIHJldHVybiAtRU5YSU87CgogICAgICAgIHN4ODY1NCA9IGRldm1fa3phbGxvYygmY2xpZW50 LT5kZXYsIHNpemVvZigqc3g4NjU0KSwgR0ZQX0tFUk5FTCk7CiAgICAgICAgaWYgKCFzeDg2NTQp CiAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKCiAgICAgICAgaW5wdXQgPSBkZXZtX2lu cHV0X2FsbG9jYXRlX2RldmljZSgmY2xpZW50LT5kZXYpOwogICAgICAgIGlmICghc3g4NjU0KQog ICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07CgogICAgICAgIGlucHV0LT5uYW1lID0gIlNY ODY1NCBJMkMgVG91Y2hzY3JlZW4iOwogICAgICAgIGlucHV0LT5pZC5idXN0eXBlID0gQlVTX0ky QzsKICAgICAgICBpbnB1dC0+ZGV2LnBhcmVudCA9ICZjbGllbnQtPmRldjsKICAgICAgICBpbnB1 dC0+b3BlbiA9IHN4ODY1NF9vcGVuOwogICAgICAgIGlucHV0LT5jbG9zZSA9IHN4ODY1NF9jbG9z ZTsKCiAgICAgICAgX19zZXRfYml0KElOUFVUX1BST1BfRElSRUNULCBpbnB1dC0+cHJvcGJpdCk7 CiAgICAgICAgaW5wdXRfc2V0X2NhcGFiaWxpdHkoaW5wdXQsIEVWX0tFWSwgQlROX1RPVUNIKTsK ICAgICAgICBpbnB1dF9zZXRfYWJzX3BhcmFtcyhpbnB1dCwgQUJTX1gsIDAsIE1BWF8xMkJJVCwg MCwgMCk7CiAgICAgICAgaW5wdXRfc2V0X2Fic19wYXJhbXMoaW5wdXQsIEFCU19ZLCAwLCBNQVhf MTJCSVQsIDAsIDApOwoKICAgICAgICBzeDg2NTQtPmNsaWVudCA9IGNsaWVudDsKICAgICAgICBz eDg2NTQtPmlucHV0ID0gaW5wdXQ7CgogICAgICAgIGlucHV0X3NldF9kcnZkYXRhKHN4ODY1NC0+ aW5wdXQsIHN4ODY1NCk7CgogICAgICAgIGVycm9yID0gaTJjX3NtYnVzX3dyaXRlX2J5dGVfZGF0 YShjbGllbnQsIEkyQ19SRUdfU09GVFJFU0VULAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTT0ZUUkVTRVRfVkFMVUUpOwogICAgICAgIGlmIChlcnJvciA8IDApIHsK ICAgICAgICAgICAgICAgIGRldl9lcnIoJmNsaWVudC0+ZGV2LCAid3JpdGluZyBzb2Z0cmVzZXQg dmFsdWUgZmFpbGVkIik7CiAgICAgICAgICAgICAgICByZXR1cm4gLUVJTzsKICAgICAgICB9Cgog ICAgICAgIGVycm9yID0gaTJjX3NtYnVzX3dyaXRlX2J5dGVfZGF0YShjbGllbnQsIEkyQ19SRUdf Q0hBTk1BU0ssCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChDT05W X1ggfCBDT05WX1kpKTsKICAgICAgICBpZiAoZXJyb3IgPCAwKSB7CiAgICAgICAgICAgICAgICBk ZXZfZXJyKCZjbGllbnQtPmRldiwgIndyaXRpbmcgdG8gSTJDX1JFR19DSEFOTUFTSyBmYWlsZWQi KTsKICAgICAgICAgICAgICAgIHJldHVybiAtRUlPOwogICAgICAgIH0KCiAgICAgICAgZXJyb3Ig PSBpMmNfc21idXNfd3JpdGVfYnl0ZV9kYXRhKGNsaWVudCwgSTJDX1JFR19JUlFNQVNLLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoSVJRX1BFTlRPVUNIX1RPVUNI Q09OVkRPTkUgfAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSVJR X1BFTlJFTEVBU0UpKTsKICAgICAgICBpZiAoZXJyb3IgPCAwKSB7CiAgICAgICAgICAgICAgICBk ZXZfZXJyKCZjbGllbnQtPmRldiwgIndyaXRpbmcgdG8gSTJDX1JFR19JUlFNQVNLIGZhaWxlZCIp OwogICAgICAgICAgICAgICAgcmV0dXJuIC1FSU87CiAgICAgICAgfQoKICAgICAgICBlcnJvciA9 IGkyY19zbWJ1c193cml0ZV9ieXRlX2RhdGEoY2xpZW50LCBJMkNfUkVHX1RPVUNIMSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKENPTkRJUlEgfCBGSUxUXzdTQSkp OwogICAgICAgIGlmIChlcnJvciA8IDApIHsKICAgICAgICAgICAgICAgIGRldl9lcnIoJmNsaWVu dC0+ZGV2LCAid3JpdGluZyB0byBJMkNfUkVHX1RPVUNIMSBmYWlsZWQiKTsKICAgICAgICAgICAg ICAgIHJldHVybiAtRUlPOwogICAgICAgIH0KCiAgICAgICAgZXJyb3IgPSBkZXZtX3JlcXVlc3Rf dGhyZWFkZWRfaXJxKCZjbGllbnQtPmRldiwgY2xpZW50LT5pcnEsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIHN4ODY1NF9pcnEsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIElSUUZfVFJJR0dFUl9GQUxMSU5HIHwKSVJRRl9P TkVTSE9ULAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbGllbnQt Pm5hbWUsIHN4ODY1NCk7CiAgICAgICAgaWYgKGVycm9yKSB7CiAgICAgICAgICAgICAgICBkZXZf ZXJyKCZjbGllbnQtPmRldiwKICAgICAgICAgICAgICAgICAgICAgICAgIkZhaWxlZCB0byBlbmFi bGUgSVJRICVkLCBlcnJvcjogJWRcbiIsCiAgICAgICAgICAgICAgICAgICAgICAgIGNsaWVudC0+ aXJxLCBlcnJvcik7CiAgICAgICAgICAgICAgICByZXR1cm4gZXJyb3I7CiAgICAgICAgfQoKICAg ICAgICAvKiBEaXNhYmxlIHRoZSBJUlEsIHdlJ2xsIGVuYWJsZSBpdCBpbiBzeDg2NTRfb3Blbigp ICovCiAgICAgICAgZGlzYWJsZV9pcnEoY2xpZW50LT5pcnEpOwoKICAgICAgICBlcnJvciA9IGlu cHV0X3JlZ2lzdGVyX2RldmljZShzeDg2NTQtPmlucHV0KTsKICAgICAgICBpZiAoZXJyb3IpCiAg ICAgICAgICAgICAgICByZXR1cm4gZXJyb3I7CgogICAgICAgIGkyY19zZXRfY2xpZW50ZGF0YShj bGllbnQsIHN4ODY1NCk7CiAgICAgICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyBjb25zdCBzdHJ1Y3Qg b2ZfZGV2aWNlX2lkIHN4ODY1NF9vZl9tYXRjaFtdID0gewogICAgICAgIHsgLmNvbXBhdGlibGUg PSAic2VtdGVjaCxzeDg2NTQiLCB9LAogICAgICAgIHsgfSwKfTsKTU9EVUxFX0RFVklDRV9UQUJM RShvZiwgc3g4NjU0X29mX21hdGNoKTsKCnN0YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9p ZCBzeDg2NTRfaWRfdGFibGVbXSA9IHsKICAgICAgICB7ICJzZW10ZWNoX3N4ODY1NCIsIDAgfSwK ICAgICAgICB7IH0sCn07Ck1PRFVMRV9ERVZJQ0VfVEFCTEUoaTJjLCBzeDg2NTRfaWRfdGFibGUp OwoKc3RhdGljIHN0cnVjdCBpMmNfZHJpdmVyIHN4ODY1NF9kcml2ZXIgPSB7CiAgICAgICAgLmRy aXZlciA9IHsKICAgICAgICAgICAgICAgIC5uYW1lID0gInN4ODY1NCIsCiAgICAgICAgICAgICAg ICAub3duZXIgPSBUSElTX01PRFVMRSwKICAgICAgICAgICAgICAgIC5vZl9tYXRjaF90YWJsZSA9 IHN4ODY1NF9vZl9tYXRjaCwKICAgICAgICB9LAoKICAgICAgICAuaWRfdGFibGUgPSBzeDg2NTRf aWRfdGFibGUsCiAgICAgICAgLnByb2JlID0gc3g4NjU0X3Byb2JlLAp9Owptb2R1bGVfaTJjX2Ry aXZlcihzeDg2NTRfZHJpdmVyKTsKCk1PRFVMRV9BVVRIT1IoIlPDqWJhc3RpZW4gU3p5bWFuc2tp IDxzZWJhc3RpZW4uc3p5bWFuc2tpQGFybWFkZXVzLmNvbT4iKTsKTU9EVUxFX0RFU0NSSVBUSU9O KCJTZW10ZWNoIFNYODY1NCBJMkMgVG91Y2hzY3JlZW4gRHJpdmVyIik7Ck1PRFVMRV9MSUNFTlNF KCJHUEwiKTsKCgpXaGVuIEkgcmV2ZXJ0IGNvbW1pdCBlNGRmM2EwIChpMmM6IGNvcmU6IERpc3Bv c2UgT0YgSVJRIG1hcHBpbmcgYXQKY2xpZW50IHJlbW92YWwgdGltZSkgSSBkb24ndCBnZXQgdGhl IHdhcm5pbmcuCgpJcyB0aGlzIGEgYnVnIGluIHRoZSBpMmMtY29yZSBvciBhbSBJIGRvaW5nIHNv bWV0aGluZyB3cm9uZyBpbiBteSBkcml2ZXI/CgotLSAKU8OpYmFzdGllbiBTWllNQU5TS0kKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastien.szymanski@armadeus.com (=?UTF-8?B?U8OpYmFzdGllbiBTWllNQU5TS0k=?=) Date: Fri, 27 Feb 2015 12:09:51 +0100 Subject: Bug in i2c-core? Message-ID: <54F0507F.6030804@armadeus.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, I am writing an I2C touchscreen driver for an i.MX6 based board. I compiled it as a module and when I unload it, I get the following warning: # modprobe sx8654 [ 46.261494] input: SX8654 I2C Touchscreen as /devices/soc0/soc/2100000.aips-bus/21a0000.i2c/i2c-0/0-0048/input/input1 # rmmod sx8654 [ 76.435223] ------------[ cut here ]------------ [ 76.439909] WARNING: CPU: 0 PID: 134 at fs/proc/generic.c:552 remove_proc_entry+0x148/0x164() [ 76.448582] remove_proc_entry: removing non-empty directory 'irq/208', leaking at least 'sx8654' [ 76.457445] Modules linked in: sx8654(-) [ 76.461452] CPU: 0 PID: 134 Comm: rmmod Not tainted 4.0.0-rc1-00002-g30f95ab-dirty #6 [ 76.469380] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 76.475977] Backtrace: [ 76.478504] [<80012638>] (dump_backtrace) from [<80012854>] (show_stack+0x18/0x1c) [ 76.486164] r7:80151e04 r6:809dd4b0 r5:00000000 r4:00000000 [ 76.491990] [<8001283c>] (show_stack) from [<806ea6cc>] (dump_stack+0x8c/0xa4) [ 76.499340] [<806ea640>] (dump_stack) from [<8002add4>] (warn_slowpath_common+0x7c/0xb8) [ 76.507509] r7:80151e04 r6:00000228 r5:00000009 r4:bdacbdb8 [ 76.513311] [<8002ad58>] (warn_slowpath_common) from [<8002ae48>] (warn_slowpath_fmt+0x38/0x40) [ 76.522110] r8:8000ee04 r7:809d1360 r6:be038e80 r5:be038ef5 r4:80898a18 [ 76.529027] [<8002ae14>] (warn_slowpath_fmt) from [<80151e04>] (remove_proc_entry+0x148/0x164) [ 76.537728] r3:806fa800 r2:80898a18 [ 76.541385] r4:bda01e80 [ 76.543983] [<80151cbc>] (remove_proc_entry) from [<80076390>] (unregister_irq_proc+0x94/0xb8) [ 76.552715] r6:000000d0 r5:8120edb8 r4:be0c1100 [ 76.557485] [<800762fc>] (unregister_irq_proc) from [<8006ee50>] (free_desc+0x34/0x6c) [ 76.565450] r6:000000d0 r5:809d1354 r4:be0c1100 [ 76.570127] [<8006ee1c>] (free_desc) from [<8006eed0>] (irq_free_descs+0x48/0x84) [ 76.577636] r7:00000001 r6:000000d0 r5:000000d1 r4:000000d1 [ 76.583383] [<8006ee88>] (irq_free_descs) from [<80075308>] (irq_dispose_mapping+0x40/0x5c) [ 76.591761] r7:00000081 r6:be1cb454 r5:be1cb420 r4:000000d0 [ 76.597519] [<800752c8>] (irq_dispose_mapping) from [<804b18b4>] (i2c_device_remove+0x68/0x88) [ 76.606178] r5:be1cb420 r4:00000000 [ 76.609806] [<804b184c>] (i2c_device_remove) from [<8039ecf0>] (__device_release_driver+0x78/0xcc) [ 76.618810] r5:7f000784 r4:be1cb420 [ 76.622432] [<8039ec78>] (__device_release_driver) from [<8039f468>] (driver_detach+0xbc/0xc0) [ 76.631068] r5:7f000784 r4:be1cb420 [ 76.634720] [<8039f3ac>] (driver_detach) from [<8039ea18>] (bus_remove_driver+0x54/0xa8) [ 76.642814] r7:00000081 r6:00003435 r5:7ee68a78 r4:7f000784 [ 76.648570] [<8039e9c4>] (bus_remove_driver) from [<8039fac8>] (driver_unregister+0x30/0x50) [ 76.657056] r5:7ee68a78 r4:7f000784 [ 76.660679] [<8039fa98>] (driver_unregister) from [<804b2aa0>] (i2c_del_driver+0x20/0x28) [ 76.668893] r5:7ee68a78 r4:7f000768 [ 76.672522] [<804b2a80>] (i2c_del_driver) from [<7f000448>] (sx8654_driver_exit+0x14/0x1c [sx8654]) [ 76.681593] r5:7ee68a78 r4:7f0007d4 [ 76.685257] [<7f000434>] (sx8654_driver_exit [sx8654]) from [<800967e8>] (SyS_delete_module+0x120/0x1c4) [ 76.694773] [<800966c8>] (SyS_delete_module) from [<8000ec40>] (ret_fast_syscall+0x0/0x4c) [ 76.703058] r5:36387873 r4:00025014 [ 76.706691] ---[ end trace c92a3e03b1c63abc ]--- My driver is similar to other touchscreen drivers, i.e. ar1021_i2c.c. /* * drivers/input/touchscreen/sx8654.c * * Copyright (c) 2015 Armadeus Systems * S?bastien Szymanski * * Using code from: * - sx865x.c * Copyright (c) 2013 U-MoBo Srl * Pierluigi Passaro * - sx8650.c * Copyright (c) 2009 Wayne Roberts * - tsc2007.c * Copyright (c) 2008 Kwangwoo Lee * - ads7846.c * Copyright (c) 2005 David Brownell * Copyright (c) 2006 Nokia Corporation * - corgi_ts.c * Copyright (C) 2004-2005 Richard Purdie * - omap_ts.[hc], ads7846.h, ts_osk.c * Copyright (C) 2002 MontaVista Software * Copyright (C) 2004 Texas Instruments * Copyright (C) 2005 Dirk Behme * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #include #include #include #include #include #include /* register addresses */ #define I2C_REG_TOUCH0 0x00 #define I2C_REG_TOUCH1 0x01 #define I2C_REG_CHANMASK 0x04 #define I2C_REG_IRQMASK 0x22 #define I2C_REG_IRQSRC 0x23 #define I2C_REG_SOFTRESET 0x3f /* commands */ #define CMD_READ_REGISTER 0x40 #define CMD_MANUAL 0xc0 #define CMD_PENTRG 0xe0 /* value for I2C_REG_SOFTRESET */ #define SOFTRESET_VALUE 0xde /* bits for I2C_REG_IRQSRC */ #define IRQ_PENTOUCH_TOUCHCONVDONE 0x08 #define IRQ_PENRELEASE 0x04 /* bits for RegTouch1 */ #define CONDIRQ 0x20 #define FILT_7SA 0x03 /* bits for I2C_REG_CHANMASK */ #define CONV_X 0x80 #define CONV_Y 0x40 /* coordinates rate: higher nibble of CTRL0 register */ #define RATE_MANUAL 0x00 #define RATE_5000CPS 0xf0 /* power delay: lower nibble of CTRL0 register */ #define POWDLY_IMMEDIATE 0x00 #define POWDLY_1_1MS 0x0b #define MAX_12BIT ((1 << 12) - 1) struct sx8654 { struct input_dev *input; struct i2c_client *client; }; static irqreturn_t sx8654_irq(int irq, void *handle) { struct sx8654 *sx8654 = handle; u8 irqsrc; u8 data[4]; unsigned int x, y; int retval; irqsrc = i2c_smbus_read_byte_data(sx8654->client, (CMD_READ_REGISTER | I2C_REG_IRQSRC)); dev_dbg(&sx8654->client->dev, "irqsrc = 0x%x", irqsrc); if (irqsrc < 0) goto out; if (irqsrc & IRQ_PENRELEASE) { dev_dbg(&sx8654->client->dev, "pen release interrupt"); input_report_key(sx8654->input, BTN_TOUCH, 0); input_sync(sx8654->input); } if (irqsrc & IRQ_PENTOUCH_TOUCHCONVDONE) { dev_dbg(&sx8654->client->dev, "pen touch interrupt"); retval = i2c_master_recv(sx8654->client, data, sizeof(data)); if (retval != sizeof(data)) goto out; /* invalid data */ if (unlikely(data[0] & 0x80 || data[2] & 0x80)) goto out; x = ((data[0] & 0xf) << 8) | (data[1]); y = ((data[2] & 0xf) << 8) | (data[3]); input_report_abs(sx8654->input, ABS_X, x); input_report_abs(sx8654->input, ABS_Y, y); input_report_key(sx8654->input, BTN_TOUCH, 1); input_sync(sx8654->input); dev_dbg(&sx8654->client->dev, "point(%4d,%4d)\n", x, y); } out: return IRQ_HANDLED; } static int sx8654_open(struct input_dev *dev) { struct sx8654 *sx8654 = input_get_drvdata(dev); struct i2c_client *client = sx8654->client; int error; /* enable pen trigger mode */ error = i2c_smbus_write_byte_data(client, I2C_REG_TOUCH0, (RATE_5000CPS | POWDLY_1_1MS)); if (error < 0) { dev_err(&client->dev, "writing to I2C_REG_TOUCH0 failed"); return -EIO; } error = i2c_smbus_write_byte(client, CMD_PENTRG); if (error < 0) { dev_err(&client->dev, "writing command CMD_PENTRG failed"); return -EIO; } enable_irq(client->irq); return 0; } static void sx8654_close(struct input_dev *dev) { struct sx8654 *sx8654 = input_get_drvdata(dev); struct i2c_client *client = sx8654->client; int error; disable_irq(client->irq); /* enable manual mode mode */ error = i2c_smbus_write_byte(client, CMD_MANUAL); if (error < 0) { dev_err(&client->dev, "writing command CMD_MANUAL failed"); return; } error = i2c_smbus_write_byte_data(client, I2C_REG_TOUCH0, 0); if (error < 0) { dev_err(&client->dev, "writing to I2C_REG_TOUCH0 failed"); return; } } static int sx8654_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct sx8654 *sx8654; struct input_dev *input; int error; if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_READ_WORD_DATA)) return -ENXIO; sx8654 = devm_kzalloc(&client->dev, sizeof(*sx8654), GFP_KERNEL); if (!sx8654) return -ENOMEM; input = devm_input_allocate_device(&client->dev); if (!sx8654) return -ENOMEM; input->name = "SX8654 I2C Touchscreen"; input->id.bustype = BUS_I2C; input->dev.parent = &client->dev; input->open = sx8654_open; input->close = sx8654_close; __set_bit(INPUT_PROP_DIRECT, input->propbit); input_set_capability(input, EV_KEY, BTN_TOUCH); input_set_abs_params(input, ABS_X, 0, MAX_12BIT, 0, 0); input_set_abs_params(input, ABS_Y, 0, MAX_12BIT, 0, 0); sx8654->client = client; sx8654->input = input; input_set_drvdata(sx8654->input, sx8654); error = i2c_smbus_write_byte_data(client, I2C_REG_SOFTRESET, SOFTRESET_VALUE); if (error < 0) { dev_err(&client->dev, "writing softreset value failed"); return -EIO; } error = i2c_smbus_write_byte_data(client, I2C_REG_CHANMASK, (CONV_X | CONV_Y)); if (error < 0) { dev_err(&client->dev, "writing to I2C_REG_CHANMASK failed"); return -EIO; } error = i2c_smbus_write_byte_data(client, I2C_REG_IRQMASK, (IRQ_PENTOUCH_TOUCHCONVDONE | IRQ_PENRELEASE)); if (error < 0) { dev_err(&client->dev, "writing to I2C_REG_IRQMASK failed"); return -EIO; } error = i2c_smbus_write_byte_data(client, I2C_REG_TOUCH1, (CONDIRQ | FILT_7SA)); if (error < 0) { dev_err(&client->dev, "writing to I2C_REG_TOUCH1 failed"); return -EIO; } error = devm_request_threaded_irq(&client->dev, client->irq, NULL, sx8654_irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, client->name, sx8654); if (error) { dev_err(&client->dev, "Failed to enable IRQ %d, error: %d\n", client->irq, error); return error; } /* Disable the IRQ, we'll enable it in sx8654_open() */ disable_irq(client->irq); error = input_register_device(sx8654->input); if (error) return error; i2c_set_clientdata(client, sx8654); return 0; } static const struct of_device_id sx8654_of_match[] = { { .compatible = "semtech,sx8654", }, { }, }; MODULE_DEVICE_TABLE(of, sx8654_of_match); static const struct i2c_device_id sx8654_id_table[] = { { "semtech_sx8654", 0 }, { }, }; MODULE_DEVICE_TABLE(i2c, sx8654_id_table); static struct i2c_driver sx8654_driver = { .driver = { .name = "sx8654", .owner = THIS_MODULE, .of_match_table = sx8654_of_match, }, .id_table = sx8654_id_table, .probe = sx8654_probe, }; module_i2c_driver(sx8654_driver); MODULE_AUTHOR("S?bastien Szymanski "); MODULE_DESCRIPTION("Semtech SX8654 I2C Touchscreen Driver"); MODULE_LICENSE("GPL"); When I revert commit e4df3a0 (i2c: core: Dispose OF IRQ mapping at client removal time) I don't get the warning. Is this a bug in the i2c-core or am I doing something wrong in my driver? -- S?bastien SZYMANSKI