From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YRK1Y-0002hD-V3 for mharc-grub-devel@gnu.org; Fri, 27 Feb 2015 07:28:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRK1V-0002e8-Df for grub-devel@gnu.org; Fri, 27 Feb 2015 07:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRK1S-0008Ky-KR for grub-devel@gnu.org; Fri, 27 Feb 2015 07:28:05 -0500 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:43519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRK1S-0008Ku-Du for grub-devel@gnu.org; Fri, 27 Feb 2015 07:28:02 -0500 Received: by wesu56 with SMTP id u56so20001726wes.10 for ; Fri, 27 Feb 2015 04:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=m3924McVSkcEr2w2FQmHcTWFshHwwBdlldgxjNWaC30=; b=l+JCnjMD2Ui9cD1OS2RzZ8+nL0DanzEZEpObJrR0GPURyDNmXPx28gsA+9lTGwVpn7 N9uIn3jgImfxKfz/M5zLkAbTfvsZVx4O2bmWWFF2LrJlI9qlbew8MofC9WFOyzQpEpLu 6cZim8YspWVAPRCeWuC/QJjU1x9ImtfMeCnG5vcu9hu6uish8n4azXkCMiLWUsAJxwPQ +r/wA1R/Beh8ohQ5OmEXHmEPGps80ZjNFc5e3ySN2KqP5gxlL9zHOyi7GIxFrc8TDaD+ HfRmQqsVAUmtqtJRQUi+wd9hSoi94piyzPn6BQj6/Z8ZX+cJUQTz5MdHwvgWbai4j5o5 7BVg== X-Received: by 10.180.84.166 with SMTP id a6mr6047718wiz.4.1425040081708; Fri, 27 Feb 2015 04:28:01 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id fo9sm2591874wib.16.2015.02.27.04.28.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2015 04:28:01 -0800 (PST) Message-ID: <54F062D0.6060007@gmail.com> Date: Fri, 27 Feb 2015 13:28:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device References: <54F05B72.3060503@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 12:28:07 -0000 On 27.02.2015 13:06, Andrei Borzenkov wrote: > On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 27.02.2015 12:47, Fajar A. Nugraha wrote: >>> >>> + lua_pushstring (state, label); >> >> What happens if label is NULL? >> > > In all cases if grub could mount filesystem it returns strdup(label). > Is it possible that mount fails without setting grub_errno? If yes, it > is probably a bug. > Nope. If filesystem has no label (rather than just empty label), it will have *label == NULL and return no error which is correct. Same for UUID. So unless lua_pushstring has special handling for NULL, this code needs to be fixed. >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >