From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals. Date: Fri, 27 Feb 2015 14:16:40 +0100 Message-ID: <54F06E38.5020608@metafoo.de> References: <1424950347-26241-1-git-send-email-dobatog@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-149.synserver.de (smtp-out-153.synserver.de [212.40.185.153]) by alsa0.perex.cz (Postfix) with ESMTP id 04627260703 for ; Fri, 27 Feb 2015 14:16:40 +0100 (CET) In-Reply-To: <1424950347-26241-1-git-send-email-dobatog@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Gabriel Dobato , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org Cc: moinejf@free.fr, alsa-devel@alsa-project.org, Takashi Iwai , Xiubo Li , Liam Girdwood , Max Filippov , Mark Brown , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 02/26/2015 12:32 PM, Gabriel Dobato wrote: > From: dobatog > > The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23: > > tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input > > I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported. > > Tested on CM-510 (Compulab SoM Board). > > Signed-off-by: dobatog Hi, The patch itself looks good, but the commit message needs some work. The subject line should be something like "ASoC: tlv320aic23: ..." to indicate that this is for the ASoC subsystem and the tlv320aic23 driver. The commit message should be line-wrapped at around 76 characters. Signed-off-by and From tag need to have your full name. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Fri, 27 Feb 2015 14:16:40 +0100 Subject: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals. In-Reply-To: <1424950347-26241-1-git-send-email-dobatog@gmail.com> References: <1424950347-26241-1-git-send-email-dobatog@gmail.com> Message-ID: <54F06E38.5020608@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/26/2015 12:32 PM, Gabriel Dobato wrote: > From: dobatog > > The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23: > > tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input > > I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported. > > Tested on CM-510 (Compulab SoM Board). > > Signed-off-by: dobatog Hi, The patch itself looks good, but the commit message needs some work. The subject line should be something like "ASoC: tlv320aic23: ..." to indicate that this is for the ASoC subsystem and the tlv320aic23 driver. The commit message should be line-wrapped at around 76 characters. Signed-off-by and From tag need to have your full name. - Lars From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbB0NQo (ORCPT ); Fri, 27 Feb 2015 08:16:44 -0500 Received: from smtp-out-153.synserver.de ([212.40.185.153]:1338 "EHLO smtp-out-149.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750777AbbB0NQn (ORCPT ); Fri, 27 Feb 2015 08:16:43 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 31252 Message-ID: <54F06E38.5020608@metafoo.de> Date: Fri, 27 Feb 2015 14:16:40 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Gabriel Dobato , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org CC: moinejf@free.fr, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Max Filippov , Xiubo Li , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals. References: <1424950347-26241-1-git-send-email-dobatog@gmail.com> In-Reply-To: <1424950347-26241-1-git-send-email-dobatog@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2015 12:32 PM, Gabriel Dobato wrote: > From: dobatog > > The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23: > > tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input > tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input > tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input > tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input > > I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported. > > Tested on CM-510 (Compulab SoM Board). > > Signed-off-by: dobatog Hi, The patch itself looks good, but the commit message needs some work. The subject line should be something like "ASoC: tlv320aic23: ..." to indicate that this is for the ASoC subsystem and the tlv320aic23 driver. The commit message should be line-wrapped at around 76 characters. Signed-off-by and From tag need to have your full name. - Lars