Re: [PATCH] xen/arm: Handle translated addresses for hardware domains in GICv2

[Julien Grall <julien.grall@linaro.org>]

On 27/02/15 13:57, Ian Campbell wrote:
> On Fri, 2015-02-27 at 13:53 +0000, Julien Grall wrote:
>> Hi Frediano,
>>
>> On 25/02/15 13:21, Frediano Ziglio wrote:
>>> Translated addresses (in d->arch.vgic.{c,d}base) are now bus addresses
>>> which could not always be applied to the DT.
>>> Copy the original addresses from DT directly to get the original
>>> untranslated reg property which will give same d->arch.vgic.{c,d}base
>>> values once translated again.
>>>
>>> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
>>> ---
>>>  xen/arch/arm/gic-v2.c | 25 ++++++++++++++-----------
>>>  1 file changed, 14 insertions(+), 11 deletions(-)
>>>
>>> Fixed typos in comments.
>>>
>>> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
>>> index 31fb81a..a401e3f 100644
>>> --- a/xen/arch/arm/gic-v2.c
>>> +++ b/xen/arch/arm/gic-v2.c
>>> @@ -590,7 +590,7 @@ static int gicv2_make_dt_node(const struct domain *d,
>>>      const struct dt_device_node *gic = dt_interrupt_controller;
>>>      const void *compatible = NULL;
>>>      u32 len;
>>> -    __be32 *new_cells, *tmp;
>>> +    const __be32 *regs;
>>>      int res = 0;
>>>  
>>>      compatible = dt_get_property(gic, "compatible", &len);
>>> @@ -617,18 +617,21 @@ static int gicv2_make_dt_node(const struct domain *d,
>>>      if ( res )
>>>          return res;
>>>  
>>> -    len = dt_cells_to_size(dt_n_addr_cells(node) + dt_n_size_cells(node));
>>> -    len *= 2; /* GIC has two memory regions: Distributor + CPU interface */
>>> -    new_cells = xzalloc_bytes(len);
>>> -    if ( new_cells == NULL )
>>> -        return -FDT_ERR_XEN(ENOMEM);
>>> +    /*
>>> +     * DTB provides up to 4 regions to handle virtualization
>>
>> Sorry to ask more change.
>>
>> I'm not sure why you speak about virtualization here.
> 
> Because two of the regions are GICH and GICV, and those are the ones we
> are truncating out here.

I though about it but I wasn't sure if he meant that.

Regards,

-- 
Julien Grall