From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v4] Add Nuvoton NCT7904 hwmon driver
Date: Fri, 27 Feb 2015 14:20:30 +0000 [thread overview]
Message-ID: <54F07D2E.8020106@roeck-us.net> (raw)
In-Reply-To: <1425042960.8163.64.camel@vvlasov.dev.rtsoft.ru>
On 02/27/2015 05:16 AM, Vadim V. Vlasov wrote:
> Signed-off-by: Vadim V. Vlasov <vvlasov@dev.rtsoft.ru>
> ---
> Changes from v3:
> 1. Added Documentation/hwmon/nct7904
> 2. Removed X86 dependency from Kconfig
> 3. Fan mode may be only 0 or 1 (for manual/smartfan)
> selecting smartfan mode is allowed only if the mode
> has been previously set up
> 4. Minor style fixes
>
> Documentation/hwmon/nct7904 | 61 +++++
Nicely done.
You introduced a couple of whitespace errors in this file.
No need to resubmit, I fixed it up.
I also dropped the now redundant comment about not supported features
from the driver code.
Thanks, applied to -next.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2015-02-27 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 13:16 [lm-sensors] [PATCH v4] Add Nuvoton NCT7904 hwmon driver Vadim V. Vlasov
2015-02-27 14:20 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F07D2E.8020106@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.