From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YRLyg-00020f-ES for mharc-grub-devel@gnu.org; Fri, 27 Feb 2015 09:33:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRLyd-0001z6-Vs for grub-devel@gnu.org; Fri, 27 Feb 2015 09:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRLya-0004e0-0Y for grub-devel@gnu.org; Fri, 27 Feb 2015 09:33:15 -0500 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:43073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRLyZ-0004dw-QH for grub-devel@gnu.org; Fri, 27 Feb 2015 09:33:11 -0500 Received: by wesu56 with SMTP id u56so20738517wes.10 for ; Fri, 27 Feb 2015 06:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=sgvMFeRLynN5sHLVCaCgiohSkswS+zqYcRUCjCsWJLc=; b=YRjcemMoTnmKIV7clfcpcygeBwoP/JZBI5oIzJ/tDsWBlfnqWImSN/FqfLN3bvaKzF V3ZzNlqQK/kCX7rE5G8DagszSqJfAJ0RlsXkIYw2jP4KMg/rgt8hX/yecsN/N1FYEFTt Ac4CvHnwbvNGUJsM/wxQTqk/RMoGnz+FF8JjhDegUgQN8eAeNQTea8AUIu+W2dCBPGCx tIU1Y0XfBtrp3QJn4FHD2dXaHkenL4DKOeamvNIobiCvghm5tXGFAkCyultpwqOySA7i CTtOKZo/wsN2q80OVTFT7JgzWVN6m0J7xkrS07tUaXONkg6zCI2liR6IHWFcYTt7RGGO lccg== X-Received: by 10.180.20.177 with SMTP id o17mr6949281wie.66.1425047590913; Fri, 27 Feb 2015 06:33:10 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id n1sm3069001wib.11.2015.02.27.06.33.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2015 06:33:10 -0800 (PST) Message-ID: <54F08025.4090808@gmail.com> Date: Fri, 27 Feb 2015 15:33:09 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device References: <54F05B72.3060503@gmail.com> <54F062D0.6060007@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 14:33:17 -0000 On 27.02.2015 15:15, Andrei Borzenkov wrote: > On Fri, Feb 27, 2015 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 27.02.2015 13:06, Andrei Borzenkov wrote: >>> >>> On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko >>> wrote: >>>> >>>> On 27.02.2015 12:47, Fajar A. Nugraha wrote: >>>>> >>>>> >>>>> + lua_pushstring (state, label); >>>> >>>> >>>> What happens if label is NULL? >>>> >>> >>> In all cases if grub could mount filesystem it returns strdup(label). >>> Is it possible that mount fails without setting grub_errno? If yes, it >>> is probably a bug. >>> >> Nope. If filesystem has no label (rather than just empty label), it will >> have *label == NULL and return no error which is correct. > > If filesystem has no label it should not define fs->label. Which > filesystem defines fs->label but returns NULL label? > HFS+. Filesystem in general has labels but a given instance may not have a label. >> Same for UUID. So >> unless lua_pushstring has special handling for NULL, this code needs to be >> fixed. >> >>>> _______________________________________________ >>>> Grub-devel mailing list >>>> Grub-devel@gnu.org >>>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >