From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Duy Nguyen <pclouds@gmail.com>,
Noel Grandin <noel@peralex.com>, git <git@vger.kernel.org>
Subject: Re: feature request: excluding files/paths from "git grep"
Date: Fri, 27 Feb 2015 16:13:13 +0100 [thread overview]
Message-ID: <54F08989.2050504@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqr3tcl78o.fsf@gitster.dls.corp.google.com>
Junio C Hamano venit, vidit, dixit 26.02.2015 21:59:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> So, as a summary of the discussion, it seems it's time to switch the
>> default to --textconv for git grep?
>
> Hmmm, why?
>
> Nobody seems to be asking for such a change in this thread. The
> original issue IIRC was that the grep output was unnecessary for
> some paths and the repository did not mark these paths as such.
> Once they are marked as "-diff", there is no reason why you want to
> trigger textconv to squelch the hits from grep.
Of course not. All that I want, and that I wanted back then, was to have
diff and grep behave the same.
> So that does not sound to me a summary of the discussion at all.
>
Well, your conditional
> I do not recall its conclusion, but it it were "Yes, that is what it
> means", then it might be reasonable to:
>
> - have "git grep" ignore paths marked with -diff by default
> (perhaps "-a" option to disable, just like GNU)
>
> - have "git grep" pay attention to diff.textconv and search in the
> result of textconv filter.
and Jeff's "Yes" on that condition certainly read like that to me: Make
"git grep" react to "diff", "-diff" attributes in the same way as "git
diff".
But I've set up my alias greppp since then and don't care any more, and
I won't invest anything in this topic any more.
Michael
next prev parent reply other threads:[~2015-02-27 15:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 12:23 feature request: excluding files/paths from "git grep" Noel Grandin
2015-02-25 13:46 ` Duy Nguyen
2015-02-25 14:31 ` Jeff King
2015-02-25 18:33 ` Junio C Hamano
2015-02-25 18:51 ` Jeff King
2015-02-25 19:01 ` Junio C Hamano
2015-02-25 19:11 ` Jeff King
2015-02-26 11:16 ` Michael J Gruber
2015-02-26 11:58 ` Duy Nguyen
2015-02-26 20:59 ` Junio C Hamano
2015-02-27 15:13 ` Michael J Gruber [this message]
2015-02-27 19:17 ` Junio C Hamano
2015-02-27 10:04 ` Trevor Saunders
2015-03-01 3:06 ` Junio C Hamano
2015-03-01 13:03 ` Trevor Saunders
2015-03-01 23:22 ` Junio C Hamano
2015-03-02 12:50 ` Trevor Saunders
2015-03-04 11:25 ` Noel Grandin
2015-03-04 20:56 ` Junio C Hamano
2015-03-05 5:22 ` Jeff King
2015-03-05 6:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F08989.2050504@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=noel@peralex.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.