From: Jens Axboe <axboe@kernel.dk>
To: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] fio: fix cycles_start build issue
Date: Fri, 27 Feb 2015 08:20:28 -0700 [thread overview]
Message-ID: <54F08B3C.1080102@kernel.dk> (raw)
In-Reply-To: <54F02B6C.8080506@linux.vnet.ibm.com>
On 02/27/2015 01:31 AM, Christian Ehrhardt wrote:
> Hi,
> a recent checkout of fio-git revealed a build issue on s390.
> For whatever reason my git send-email setup is broken so I paste it in
> the mail and hope it doesn't get mangled, let me know if that fails.
It mangled it horribly, but I just hand applied it. One issue, though:
> diff --git a/arch/arch-generic.h b/arch/arch-generic.h
> index a0b71f8..825a829 100644
> --- a/arch/arch-generic.h
> +++ b/arch/arch-generic.h
> @@ -2,6 +2,7 @@
> #define ARCH_GENERIC_H
>
> #define FIO_ARCH (arch_generic)
> +#define ARCH_CPU_CLOCK_WRAPS
This wont work like I suspect you think it does. This define needs to go
in the arch.h header, if you want all archs to catch it.
--
Jens Axboe
next prev parent reply other threads:[~2015-02-27 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 8:31 [PATCH] fio: fix cycles_start build issue Christian Ehrhardt
2015-02-27 15:20 ` Jens Axboe [this message]
2015-03-02 8:22 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F08B3C.1080102@kernel.dk \
--to=axboe@kernel.dk \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.