From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>, netdev@vger.kernel.org
Cc: linux-kernel@lists.codethink.co.uk,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH net-next 2/5] sh_eth: WARN on access to a register not implemented in a particular chip
Date: Fri, 27 Feb 2015 18:21:24 +0300 [thread overview]
Message-ID: <54F08B74.4000409@cogentembedded.com> (raw)
In-Reply-To: <1424982854.4444.73.camel@xylophone.i.decadent.org.uk>
Hello.
On 2/26/2015 11:34 PM, Ben Hutchings wrote:
> Currently we may silently read/write a register at offset 0. Change
> this to WARN and then ignore the write or read-back all-ones.
I think reading non-existing registers would yield all 0s, not all 1s.
That's not x86. :-)
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Other than that, seems a great idea.
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
next prev parent reply other threads:[~2015-02-27 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 20:31 [PATCH net-next 0/5] sh_eth changes for net-next Ben Hutchings
2015-02-26 20:33 ` [PATCH net-next 1/5] sh_eth: Implement multicast statistic based on the RFS8 status bit Ben Hutchings
2015-02-26 20:34 ` [PATCH net-next 2/5] sh_eth: WARN on access to a register not implemented in a particular chip Ben Hutchings
2015-02-27 15:21 ` Sergei Shtylyov [this message]
2015-03-05 9:02 ` [net-next, " Geert Uytterhoeven
2015-03-05 13:18 ` Ben Hutchings
2015-03-09 8:50 ` [Linux-kernel] " Ben Dooks
2015-03-10 20:03 ` Sergei Shtylyov
2015-02-26 20:34 ` [PATCH net-next 3/5] sh_eth: Implement ethtool register dump operations Ben Hutchings
2015-02-26 20:34 ` [PATCH net-next 4/5] sh_eth: Optionally log RX and TX status for each completed descriptor Ben Hutchings
2015-02-26 20:35 ` [PATCH net-next 5/5] sh_eth: Mitigate lost statistics updates Ben Hutchings
2015-03-02 20:34 ` [PATCH net-next 0/5] sh_eth changes for net-next David Miller
2015-03-04 20:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F08B74.4000409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=ykaneko0929@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.