All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Konno <joe.konno@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Redo WMs when cursor size changes
Date: Fri, 27 Feb 2015 08:21:34 -0800	[thread overview]
Message-ID: <54F0998E.3060702@linux.intel.com> (raw)
In-Reply-To: <20150227145309.GK24485@phenom.ffwll.local>

On 02/27/2015 06:53 AM, Daniel Vetter wrote:
> On Thu, Feb 26, 2015 at 05:47:35PM -0800, Matt Roper wrote:
>> So your patch below could result in sleeps happening while vblanks are
>> disabled, which is bad (IIRC, most of those sleeps are in the SKL
>> codepath right now, but I think there's a workaround-related wait for
>> IVB as well).
>>
>> Our watermark code needs a lot of work to beat it into proper shape for
>> atomic and that's what I'm working on at the moment.
> 
> Alternative issue is that wm recompute happens before we update all the
> legacy state. Tvrkto just stumbled over that for some of his skl watermark
> code, he had to switch a few places in the wm code from looking at
> plane->fb to look at plane->state->fb.
> 
> Similar changes might be needed for the cursor wm code -
> cursor_width/height is kinda redundant since universal planes support.

Thanks for the insights, Matt and Dan. It's clear to me from Matt's analysis
that my patch is a hack at best and nowhere near a proper fix.

This patch was submitted in the hopes of fixing a substantial graphical
regression. Shall my patch be retooled as a "better" work-around, or will the
regression stand until the watermark code is beat into proper shape?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-02-27 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 22:48 [PATCH] drm/i915: Redo WMs when cursor size changes Joe Konno
2015-02-27  1:14 ` Ausmus, James
2015-02-27  1:47 ` Matt Roper
2015-02-27 14:53   ` Daniel Vetter
2015-02-27 16:21     ` Joe Konno [this message]
2015-02-27 16:24       ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F0998E.3060702@linux.intel.com \
    --to=joe.konno@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.