From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v6 02/23] xen: move NUMA_NO_NODE to public memory.h as XEN_NUMA_NO_NODE Date: Fri, 27 Feb 2015 16:52:42 +0000 Message-ID: <54F0A0DA.8020809@citrix.com> References: <1424966166-2388-1-git-send-email-wei.liu2@citrix.com> <1424966166-2388-3-git-send-email-wei.liu2@citrix.com> <54F0AC920200007800064BFB@mail.emea.novell.com> <20150227165139.GF29195@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150227165139.GF29195@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 27/02/15 16:51, Wei Liu wrote: > On Fri, Feb 27, 2015 at 04:42:42PM +0000, Jan Beulich wrote: >>>>> On 26.02.15 at 16:55, wrote: >>> Update NUMA_NO_NODE in Xen code to use the new macro. >>> >>> No functional change introduced. >> But also no explanation given why this is being done. After all just >> leaving out the explicit specification on a node in the memop flags >> has the effect of saying NUMA_NO_NODE. >> > During last round review, Andrew wanted me to move this to Xen public > header to avoid reinventing it in libxc. Now this value is used in libxc > patch. > > But I don't particularly mind whether we move it or not, it's up to you > maintainers to decide. It is a sentinel value used in the public ABI. It should therefore appear in the public API. ~Andrew