[Cluster-devel] [PATCH RHEL6] libgfs2: Use a matching context mount option in mount_gfs2_meta

[Andrew Price <anprice@redhat.com>]

On 27/02/15 17:17, Bob Peterson wrote:
> ----- Original Message -----
>> On a system with SELinux enabled, if a gfs2 file system is mounted with
>> a context= option, the tools gfs2_quota, gfs2_tool, gfs2_grow and
>> gfs2_jadd will fail with "Device or resource busy". This is due to
>> SELinux failing the mount due to a mismatched context ("SELinux: mount
>> invalid.  Same superblock, different security settings").
>>
>> In order to work around this, parse the context option of the gfs2 mount
>> point in is_pathname_mounted() and use it in mount_gfs2_meta().

> Hi,
>
> Is this a memory leak (albeit a small one) or did I miss something?
> I don't see where the memory allocate by strndup is ever freed.

Well spotted. It is a tiny leak, but it couldn't hurt to plug it. I've 
checked that it isn't present in the upstream version of the patch so 
it's just this version which needs to be fixed. I'll send a follow-up 
patch shortly.

Thanks,
Andy