From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPaX-0001FC-FV for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:24:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRPaT-00034Z-Fx for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:24:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41173 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPaT-00034M-Ab for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:24:33 -0500 Message-ID: <54F0B65F.2050607@suse.de> Date: Fri, 27 Feb 2015 19:24:31 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <54E9DA4D.1050702@sunrus.com.cn> <54E9DB99.2000303@sunrus.com.cn> In-Reply-To: <54E9DB99.2000303@sunrus.com.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros which are not defined in tilegx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang S Cc: Peter Maydell , Riku Voipio , qemu-devel , Chris Metcalf , "walt@tilera.com" , "rth@twiddle.net" Am 22.02.2015 um 14:37 schrieb Chen Gang S: > For tilegx, several syscall macros are not supported, so switch them to > avoid building break. >=20 > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 50 ++++++++++++++++++++++++++++++++++++++++++++= +++++- > 1 file changed, 49 insertions(+), 1 deletion(-) LGTM, Reviewed-by: Andreas F=C3=A4rber However I suggest "conditionalize syscalls" or "disable syscalls" over "switch ... macros/them". Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)