From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPiY-000775-O4 for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:32:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRPiV-0006Du-Gb for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:32:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPiV-0006Dp-9A for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:32:51 -0500 Message-ID: <54F0B84F.7050202@redhat.com> Date: Fri, 27 Feb 2015 11:32:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425057891-29848-1-git-send-email-vsementsov@parallels.com> <1425057891-29848-12-git-send-email-vsementsov@parallels.com> In-Reply-To: <1425057891-29848-12-git-send-email-vsementsov@parallels.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9qO0iDmH4x862D8IAFAWGIpKxAHGsGDXe" Subject: Re: [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9qO0iDmH4x862D8IAFAWGIpKxAHGsGDXe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote: > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 1 + > include/qemu/hbitmap.h | 8 ++++++++ > qapi/block-core.json | 4 +++- > util/hbitmap.c | 8 ++++++++ > 4 files changed, 20 insertions(+), 1 deletion(-) >=20 > +++ b/qapi/block-core.json > @@ -336,11 +336,13 @@ > # > # @frozen: whether the dirty bitmap is frozen (Since 2.3) > # > +# @md5: md5 checksum of the last bitmap level (since 2.3) > +# > # Since: 1.3 > ## > { 'type': 'BlockDirtyInfo', > 'data': {'*name': 'str', 'count': 'int', 'granularity': 'uint32', > - 'disabled': 'bool', 'frozen': 'bool'} } > + 'disabled': 'bool', 'frozen': 'bool', 'md5': 'str'} } How long does it take to compute the md5 sum? Is enabling this information unconditionally going to significantly slow down the call, when the information is useful primarily only for debugging? That said, it looks okay code-wise, so as long as I am not uncovering a design flaw: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9qO0iDmH4x862D8IAFAWGIpKxAHGsGDXe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU8LhPAAoJEKeha0olJ0NqzZQIAKbZu9u4HOvGgZ8hfJ+DJF3B QBbYo8va+my9mQNSlFiJo/iySt98SeBvvvGWi1iM7WqmNfRo8/XEgDuFTWWMJXNk c2eStku8tLRDnh1/o1E4Z7jLSV/e78uB4ImFvt2zw+AltpsZuKUkrtcx1/+ixt7c aiyUxXAU7V64pk6DP07Nu6axg4rQUn3rz8kF/yH6qXhcvYB2umcZ0KfN0cXam9NR ZJ8Ebgeuax4u1baO9gNF3XlydZqkqymy0Qbbcla5nyl1dNlFLLl/Z/l6qfINAr3c oiwlIIYitk1CVwXBIDWiwTsmqt5n1Y3MUkmc8gwrNZGdRrAaBq5l3gWhMCRXeFI= =MVM0 -----END PGP SIGNATURE----- --9qO0iDmH4x862D8IAFAWGIpKxAHGsGDXe--