All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>,
	"David S.Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@lists.codethink.co.uk,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
	Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>,
	Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>,
	Yoshihiro Kaneko <ykaneko0929@gmail.com>
Subject: Re: [PATCH kernel 4/4] sh_eth: Fix DMA-API usage for RX buffers
Date: Fri, 27 Feb 2015 23:36:59 +0300	[thread overview]
Message-ID: <54F0D56B.8000809@cogentembedded.com> (raw)
In-Reply-To: <1422319824.3524.24.camel@xylophone.i.decadent.org.uk>

Hello.

On 01/27/2015 03:50 AM, Ben Hutchings wrote:

> - Use the return value of dma_map_single(), rather than calling
>    virt_to_page() separately
> - Check for mapping failue
> - Call dma_unmap_single() rather than dma_sync_single_for_cpu()

> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>

    I wonder whether you're aware at the previous Renesas' attemept at fixing 
DMA issues:

http://marc.info/?t=141586251000003

    It was turned down because they tried to deal with several issues in one 
patch, and they have failed to follow up. Could you look at the rest of the 
DMA issues reported (and not reported) in that patch?

[...]

WBR, Sergei

  reply	other threads:[~2015-02-27 20:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  0:40 [PATCH kernel 0/4] Fixes for sh_eth #3 Ben Hutchings
2015-01-27  0:41 ` [PATCH kernel 1/4] sh_eth: Remove RX overflow log messages Ben Hutchings
2015-01-27  0:49 ` [PATCH kernel 2/4] sh_eth: Ensure DMA engines are stopped before freeing buffers Ben Hutchings
2015-01-27  0:49 ` [PATCH kernel 3/4] sh_eth: Check for DMA mapping errors on transmit Ben Hutchings
2015-01-27  0:50 ` [PATCH kernel 4/4] sh_eth: Fix DMA-API usage for RX buffers Ben Hutchings
2015-02-27 20:36   ` Sergei Shtylyov [this message]
2015-02-28  3:06     ` Ben Hutchings
2015-01-27  0:51 ` [Linux-kernel] [PATCH kernel 0/4] Fixes for sh_eth #3 Ben Hutchings
2015-01-27  8:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F0D56B.8000809@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=davem@davemloft.net \
    --cc=hisashi.nakamura.ak@renesas.com \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=mitsuhiro.kimura.kc@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=nobuhiro.iwamatsu.yj@renesas.com \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.