From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38475)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRTzL-00070d-3W
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 18:06:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRTzH-0004WA-UI
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 18:06:31 -0500
Received: from out1134-195.mail.aliyun.com ([42.120.134.195]:48245)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRTzH-0004Uy-J4
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 18:06:27 -0500
Message-ID: <54F0F878.5000006@sunrus.com.cn>
Date: Sat, 28 Feb 2015 07:06:32 +0800
From: Chen Gang S <gang.chen@sunrus.com.cn>
MIME-Version: 1.0
References: <54E9DA4D.1050702@sunrus.com.cn> <54E9DB99.2000303@sunrus.com.cn>
	<54F0B65F.2050607@suse.de>
In-Reply-To: <54F0B65F.2050607@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all
 macros which are not defined in tilegx
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>, Chris Metcalf <cmetcalf@ezchip.com>, "walt@tilera.com" <walt@tilera.com>, "rth@twiddle.net" <rth@twiddle.net>

On 02/28/2015 02:24 AM, Andreas Färber wrote:
> Am 22.02.2015 um 14:37 schrieb Chen Gang S:
>> For tilegx, several syscall macros are not supported, so switch them to
>> avoid building break.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  linux-user/syscall.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 49 insertions(+), 1 deletion(-)
> 
> LGTM,
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> However I suggest "conditionalize syscalls" or "disable syscalls" over
> "switch ... macros/them".
> 

OK, thanks. What you said above sounds reasonable to me.

Thanks.
-- 
Open, share, and attitude like air, water, and life which God blessed.