From: Zhou Wang <wangzhou1@hisilicon.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] mtd: hisilicon: && vs & typo
Date: Sat, 28 Feb 2015 04:44:23 +0000 [thread overview]
Message-ID: <54F147A7.50701@hisilicon.com> (raw)
In-Reply-To: <20150212213740.GA18140@ld-irv-0074>
On 2015/2/13 5:37, Brian Norris wrote:
> Hi,
>
> On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
>> The intent was to mask away some bits here, not to test true or false.
>>
>> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
>> index 484e1db..289ad3a 100644
>> --- a/drivers/mtd/nand/hisi504_nand.c
>> +++ b/drivers/mtd/nand/hisi504_nand.c
>> @@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
>> flag = hinfc_read(host, HINFC504_CON);
>> if (chip->ecc.mode = NAND_ECC_HW)
>> hinfc_write(host,
>> - flag && ~(HINFC504_CON_ECCTYPE_MASK <<
>> + flag & ~(HINFC504_CON_ECCTYPE_MASK <<
>
> Looks good to me. Zhou, can I get an ack?
Hi Brian,
Sorry for late for the reason of Chinese new year vacation.
You can apply that above, My mistake there.
Thanks,
Zhou Wang
>
>> HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
>>
>> host->offset = 0;
>
> Brian
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Wang <wangzhou1@hisilicon.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] mtd: hisilicon: && vs & typo
Date: Sat, 28 Feb 2015 12:44:23 +0800 [thread overview]
Message-ID: <54F147A7.50701@hisilicon.com> (raw)
In-Reply-To: <20150212213740.GA18140@ld-irv-0074>
On 2015/2/13 5:37, Brian Norris wrote:
> Hi,
>
> On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
>> The intent was to mask away some bits here, not to test true or false.
>>
>> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
>> index 484e1db..289ad3a 100644
>> --- a/drivers/mtd/nand/hisi504_nand.c
>> +++ b/drivers/mtd/nand/hisi504_nand.c
>> @@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
>> flag = hinfc_read(host, HINFC504_CON);
>> if (chip->ecc.mode == NAND_ECC_HW)
>> hinfc_write(host,
>> - flag && ~(HINFC504_CON_ECCTYPE_MASK <<
>> + flag & ~(HINFC504_CON_ECCTYPE_MASK <<
>
> Looks good to me. Zhou, can I get an ack?
Hi Brian,
Sorry for late for the reason of Chinese new year vacation.
You can apply that above, My mistake there.
Thanks,
Zhou Wang
>
>> HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
>>
>> host->offset = 0;
>
> Brian
>
>
next prev parent reply other threads:[~2015-02-28 4:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 10:25 [patch] mtd: hisilicon: && vs & typo Dan Carpenter
2015-02-11 10:25 ` Dan Carpenter
2015-02-12 21:37 ` Brian Norris
2015-02-12 21:37 ` Brian Norris
2015-02-28 4:44 ` Zhou Wang [this message]
2015-02-28 4:44 ` Zhou Wang
2015-02-15 9:07 ` Brian Norris
2015-02-15 9:07 ` Brian Norris
2015-02-28 4:47 ` Zhou Wang
2015-02-28 4:47 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F147A7.50701@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.