From: Zhou Wang <wangzhou1@hisilicon.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
liguozhu@hisilicon.com, xuwei5@hisilicon.com,
linux-mtd@lists.infradead.org, haojian.zhuang@gmail.com,
caizhiyong@huawei.com, yubingxu@hisilicon.com,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc
Date: Sat, 28 Feb 2015 14:01:51 +0800 [thread overview]
Message-ID: <54F159CF.9090208@hisilicon.com> (raw)
In-Reply-To: <20150208083514.GD3670@norris-Latitude-E6410>
On 2015/2/8 16:35, Brian Norris wrote:
> On Sun, Jan 25, 2015 at 06:53:12PM +0800, Zhou Wang wrote:
>> This patchset adds the support for NAND controller of hisilicon hip04 Soc.
>> The NAND controller IP was developed by hisilicon and needs a new driver to
>> support it. This patchset is based on l2-mtd/master.
>>
>> I have tested this NAND flash controller driver in Hip04 D01 board using MTD
>> test modules. All testes passed except mtd_nandbiterrs. The reason is that this
>> NAND controller doesn't support to write raw page in ECC mode. In the test of
>> mtd_nandbiterrs, when rewriting raw page(with some bits changed) back, this NAND
>> controller will also produce ECC codes and write into NAND flash OOB area. As
>> ECC codes in OOB area have been broken, read error comes out as follow.
>>
>> Hi Brian,
>>
>> As the patch have been reviewed for some time, could you consider to take this
>> driver for v3.20? If there is something still not good, please let me know.
>
> It's all looking good. Pushed to l2-mtd.git, probably for 3.20. I have
> one or two small comments that may be worth thinking about though.
>
> Brian
>
> .
>
Hi Brian,
Thanks a lot.
Zhou Wang
WARNING: multiple messages have this Message-ID (diff)
From: wangzhou1@hisilicon.com (Zhou Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc
Date: Sat, 28 Feb 2015 14:01:51 +0800 [thread overview]
Message-ID: <54F159CF.9090208@hisilicon.com> (raw)
In-Reply-To: <20150208083514.GD3670@norris-Latitude-E6410>
On 2015/2/8 16:35, Brian Norris wrote:
> On Sun, Jan 25, 2015 at 06:53:12PM +0800, Zhou Wang wrote:
>> This patchset adds the support for NAND controller of hisilicon hip04 Soc.
>> The NAND controller IP was developed by hisilicon and needs a new driver to
>> support it. This patchset is based on l2-mtd/master.
>>
>> I have tested this NAND flash controller driver in Hip04 D01 board using MTD
>> test modules. All testes passed except mtd_nandbiterrs. The reason is that this
>> NAND controller doesn't support to write raw page in ECC mode. In the test of
>> mtd_nandbiterrs, when rewriting raw page(with some bits changed) back, this NAND
>> controller will also produce ECC codes and write into NAND flash OOB area. As
>> ECC codes in OOB area have been broken, read error comes out as follow.
>>
>> Hi Brian,
>>
>> As the patch have been reviewed for some time, could you consider to take this
>> driver for v3.20? If there is something still not good, please let me know.
>
> It's all looking good. Pushed to l2-mtd.git, probably for 3.20. I have
> one or two small comments that may be worth thinking about though.
>
> Brian
>
> .
>
Hi Brian,
Thanks a lot.
Zhou Wang
WARNING: multiple messages have this Message-ID (diff)
From: Zhou Wang <wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
caizhiyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
yubingxu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Subject: Re: [PATCH v8 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc
Date: Sat, 28 Feb 2015 14:01:51 +0800 [thread overview]
Message-ID: <54F159CF.9090208@hisilicon.com> (raw)
In-Reply-To: <20150208083514.GD3670@norris-Latitude-E6410>
On 2015/2/8 16:35, Brian Norris wrote:
> On Sun, Jan 25, 2015 at 06:53:12PM +0800, Zhou Wang wrote:
>> This patchset adds the support for NAND controller of hisilicon hip04 Soc.
>> The NAND controller IP was developed by hisilicon and needs a new driver to
>> support it. This patchset is based on l2-mtd/master.
>>
>> I have tested this NAND flash controller driver in Hip04 D01 board using MTD
>> test modules. All testes passed except mtd_nandbiterrs. The reason is that this
>> NAND controller doesn't support to write raw page in ECC mode. In the test of
>> mtd_nandbiterrs, when rewriting raw page(with some bits changed) back, this NAND
>> controller will also produce ECC codes and write into NAND flash OOB area. As
>> ECC codes in OOB area have been broken, read error comes out as follow.
>>
>> Hi Brian,
>>
>> As the patch have been reviewed for some time, could you consider to take this
>> driver for v3.20? If there is something still not good, please let me know.
>
> It's all looking good. Pushed to l2-mtd.git, probably for 3.20. I have
> one or two small comments that may be worth thinking about though.
>
> Brian
>
> .
>
Hi Brian,
Thanks a lot.
Zhou Wang
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-02-28 6:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 10:53 [PATCH v8 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-01-25 10:53 ` [PATCH v8 1/2] mtd: hisilicon: add a new NAND controller driver for " Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-02-08 8:42 ` Brian Norris
2015-02-08 8:42 ` Brian Norris
2015-02-08 8:42 ` Brian Norris
2015-01-25 10:53 ` [PATCH v8 2/2] mtd: hisilicon: add device tree binding documentation Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-01-25 10:53 ` Zhou Wang
2015-02-08 8:35 ` [PATCH v8 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Brian Norris
2015-02-08 8:35 ` Brian Norris
2015-02-08 8:35 ` Brian Norris
2015-02-28 6:01 ` Zhou Wang [this message]
2015-02-28 6:01 ` Zhou Wang
2015-02-28 6:01 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F159CF.9090208@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=arnd@arndb.de \
--cc=caizhiyong@huawei.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xuwei5@hisilicon.com \
--cc=yubingxu@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.