From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRnV3-0007iB-NV
	for qemu-devel@nongnu.org; Sat, 28 Feb 2015 14:56:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRnV0-0005fX-0e
	for qemu-devel@nongnu.org; Sat, 28 Feb 2015 14:56:33 -0500
Received: from out1134-235.mail.aliyun.com ([42.120.134.235]:14585)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen@sunrus.com.cn>) id 1YRnUz-0005fG-KR
	for qemu-devel@nongnu.org; Sat, 28 Feb 2015 14:56:29 -0500
Message-ID: <54F21F38.9000601@sunrus.com.cn>
Date: Sun, 01 Mar 2015 04:04:08 +0800
From: Chen Gang S <gang.chen@sunrus.com.cn>
MIME-Version: 1.0
References: <54E9DA4D.1050702@sunrus.com.cn> <54E9DA93.8000507@sunrus.com.cn>
	<54F0AB3A.9060100@suse.de> <54F15002.9060409@sunrus.com.cn>
In-Reply-To: <54F15002.9060409@sunrus.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu
 with minimized features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>, Chris Metcalf <cmetcalf@ezchip.com>, "walt@tilera.com" <walt@tilera.com>, "rth@twiddle.net" <rth@twiddle.net>

On 2/28/15 13:20, Chen Gang S wrote:
>>> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
>>> >> new file mode 100644
>>> >> index 0000000..e69de29
>> > 
>> > Is this empty file actually included from somewhere in this patch?
>> > 
> Yes, it is for future use, I guess, at present, we can just drop it:
> 
>  - "translate.c" includes "exec/helper-gen.h".
> 
>  - "exec/helper-gen.h" includes "helper.h".
> 
> 

Oh, sorry, I forgot, "tcg/tcg-op.h" -> "helper-proto.h" -> "helper.h"

    CC    tilegx-linux-user/tcg/tcg.o
  In file included from /upstream/qemu/tcg/tcg-op.h:26:0,
                   from /upstream/qemu/tcg/tcg.c:49:
  /upstream/qemu/include/exec/helper-proto.h:29:20: fatal error: helper.h: No such file or directory
   #include "helper.h"
                      ^

So for me, we have to still use an empty "helper.h" file for it.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed