From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement Date: Mon, 2 Mar 2015 10:39:22 +0000 Message-ID: <54F43DDA.20908@citrix.com> References: <1425207458-1707-1-git-send-email-yuval.shaia@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSNl1-00062a-1w for xen-devel@lists.xenproject.org; Mon, 02 Mar 2015 10:39:27 +0000 In-Reply-To: <1425207458-1707-1-git-send-email-yuval.shaia@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yuval Shaia , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 01/03/15 10:57, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia > --- > include/xen/xenbus.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h > index b78f21c..b0f1c9e 100644 > --- a/include/xen/xenbus.h > +++ b/include/xen/xenbus.h > @@ -114,9 +114,9 @@ int __must_check __xenbus_register_backend(struct xenbus_driver *drv, > const char *mod_name); > > #define xenbus_register_frontend(drv) \ > - __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME); > + __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME) Oops. Applied to stable/for-linus-4,0, thanks. However, the preferred style for a caller would be: ret = xenbus_register_frontend(...); if (ret < 0) { ... David