From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/4] vscsiif.h: remove reference to WWN Date: Mon, 2 Mar 2015 10:50:50 +0000 Message-ID: <54F4408A.8080208@citrix.com> References: <1425291362-30228-1-git-send-email-olaf@aepfle.de> <1425291362-30228-2-git-send-email-olaf@aepfle.de> <54F44D930200007800064EC7@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54F44D930200007800064EC7@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Olaf Hering Cc: Tim Deegan , xen-devel@lists.xen.org, Keir Fraser , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 02/03/15 10:46, Jan Beulich wrote: >>>> On 02.03.15 at 11:15, wrote: >> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. >> Remove incorrect reference to WWN because it was never supported. And >> its not clear how it could be supported. p-devname can be used to store >> a config string. > I'm not sure - even if a particular implementation doesn't support > certain functionality, I would say the interface definition can still > name this as a possibility. It would be misleading to suggest it is available if it is not implemented. Furthermore, Olaf's comment suggests that it cant be supported with this key, at which point the reference should absolutely be removed. ~Andrew