From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/4] vscsiif.h: remove reference to WWN
Date: Mon, 02 Mar 2015 11:59:14 +0100
Message-ID: <54F44282.1070009@suse.com>
References: <1425291362-30228-1-git-send-email-olaf@aepfle.de>
	<1425291362-30228-2-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1425291362-30228-2-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 03/02/2015 11:15 AM, Olaf Hering wrote:
> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation.
> Remove incorrect reference to WWN because it was never supported. And
> its not clear how it could be supported. p-devname can be used to store
> a config string.

The pvops backend driver should support the WWN notation. In case it
isn't working this is a bug which should be repaired.

I implemented the WWn version before adding the possibility to use
h:c:t:l due to compatibility with xend...

So: NAK.


Juergen

>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> ---
>   xen/include/public/io/vscsiif.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xen/include/public/io/vscsiif.h b/xen/include/public/io/vscsiif.h
> index 7a1db05..373ca3f 100644
> --- a/xen/include/public/io/vscsiif.h
> +++ b/xen/include/public/io/vscsiif.h
> @@ -58,9 +58,8 @@
>    * p-dev
>    *      Values:         string
>    *
> - *      A string specifying the backend device: either a 4-tuple "h:c:t:l"
> - *      (host, controller, target, lun, all integers), or a WWN (e.g.
> - *      "naa.60014054ac780582").
> + *      A string specifying the backend device in form of a 4-tuple "h:c:t:l"
> + *      (host, controller, target, lun, all integers).
>    *
>    * v-dev
>    *      Values:         string
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>