From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/4] vscsiif.h: remove reference to WWN Date: Mon, 2 Mar 2015 11:00:42 +0000 Message-ID: <54F442DA.7030409@citrix.com> References: <1425291362-30228-1-git-send-email-olaf@aepfle.de> <1425291362-30228-2-git-send-email-olaf@aepfle.de> <54F44D930200007800064EC7@mail.emea.novell.com> <54F4408A.8080208@citrix.com> <54F441BF.9030902@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <54F441BF.9030902@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?windows-1252?Q?J=FCrgen_Gro=DF?= , Jan Beulich , Olaf Hering Cc: Keir Fraser , Ian Campbell , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 02/03/15 10:55, J=FCrgen Gro=DF wrote: > On 03/02/2015 11:50 AM, Andrew Cooper wrote: >> On 02/03/15 10:46, Jan Beulich wrote: >>>>>> On 02.03.15 at 11:15, wrote: >>>> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l >>>> notation. >>>> Remove incorrect reference to WWN because it was never supported. And >>>> its not clear how it could be supported. p-devname can be used to >>>> store >>>> a config string. >>> I'm not sure - even if a particular implementation doesn't support >>> certain functionality, I would say the interface definition can still >>> name this as a possibility. >> >> It would be misleading to suggest it is available if it is not >> implemented. Furthermore, Olaf's comment suggests that it cant be >> supported with this key, at which point the reference should absolutely >> be removed. > > The pvops backend supports this variant. In which case it really should stay. ~Andrew