From: "Horia Geantă" <horia.geanta@freescale.com>
To: <yanjiang.jin@windriver.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>
Cc: <kim.phillips@freescale.com>, <ruchika.gupta@freescale.com>,
<cristian.stoica@freescale.com>, <NiteshNarayanLal@freescale.com>,
<jinyanjiang@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/4] crypto: caam: fix some compile warnings
Date: Mon, 2 Mar 2015 13:08:51 +0200 [thread overview]
Message-ID: <54F444C3.6020505@freescale.com> (raw)
In-Reply-To: <1425103234-31129-1-git-send-email-yanjiang.jin@windriver.com>
On 2/28/2015 8:00 AM, yanjiang.jin@windriver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@windriver.com>
>
> This commit is to avoid the below warnings:
>
> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning:
> 'dma_map_sg_chained' defined but not used [-Wunused-function]
> static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
> ^
> drivers/crypto/caam/sg_sw_sec4.h:104:12: warning:
> 'dma_unmap_sg_chained' defined but not used [-Wunused-function]
> static int dma_unmap_sg_chained(struct device *dev,
> ^
>
> Signed-off-by: Yanjiang Jin <yanjiang.jin@windriver.com>
Reviewed-by: Horia Geanta <horia.geanta@freescale.com>
> ---
> drivers/crypto/caam/sg_sw_sec4.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/caam/sg_sw_sec4.h b/drivers/crypto/caam/sg_sw_sec4.h
> index 3b91821..a6276eb 100644
> --- a/drivers/crypto/caam/sg_sw_sec4.h
> +++ b/drivers/crypto/caam/sg_sw_sec4.h
> @@ -85,7 +85,7 @@ static inline int sg_count(struct scatterlist *sg_list, int nbytes,
> return sg_nents;
> }
>
> -static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
> +static inline int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
> unsigned int nents, enum dma_data_direction dir,
> bool chained)
> {
> @@ -101,9 +101,9 @@ static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg,
> return nents;
> }
>
> -static int dma_unmap_sg_chained(struct device *dev, struct scatterlist *sg,
> - unsigned int nents, enum dma_data_direction dir,
> - bool chained)
> +static inline int dma_unmap_sg_chained(struct device *dev,
> + struct scatterlist *sg, unsigned int nents,
> + enum dma_data_direction dir, bool chained)
> {
> if (unlikely(chained)) {
> int i;
>
prev parent reply other threads:[~2015-03-02 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 6:00 [PATCH 1/4] crypto: caam: fix some compile warnings yanjiang.jin
2015-02-28 6:00 ` [PATCH 2/4] crypto: caam_rng: fix rng_unmap_ctx's DMA_UNMAP size problem yanjiang.jin
2015-03-02 11:09 ` Horia Geantă
2015-02-28 6:00 ` [PATCH 3/4] crypto: caamhash: add two missed dma_mapping_error yanjiang.jin
2015-03-02 11:53 ` Horia Geantă
2015-03-03 6:57 ` yjin
2015-02-28 6:00 ` [PATCH 4/4] crypto: caamhash: replace kmalloc with kzalloc yanjiang.jin
2015-03-02 11:03 ` Horia Geantă
2015-03-03 6:54 ` yjin
2015-03-02 11:08 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F444C3.6020505@freescale.com \
--to=horia.geanta@freescale.com \
--cc=NiteshNarayanLal@freescale.com \
--cc=cristian.stoica@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jinyanjiang@gmail.com \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruchika.gupta@freescale.com \
--cc=yanjiang.jin@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.