From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [PATCH v3 01/16] Introduce probe mode for machine type none Date: Mon, 02 Mar 2015 14:57:21 +0100 Message-ID: <54F46C41.3000201@suse.de> References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com> <1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: qemu-devel@nongnu.org, "Edgar E. Iglesias" , Peter Crosthwaite Cc: Michael Mueller , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Alistair Francis List-ID: Am 02.03.2015 um 13:43 schrieb Michael Mueller: > QEMU now switches into "probe mode" when the selected machine is "non= e" and no > specific accelerator(s) has been requested (i.e.: "-machine none"). >=20 > In probe mode a by "_CONFIG" defines predefined list of acceler= ators run > their init() methods. >=20 > Signed-off-by: Michael Mueller > --- > accel.c | 31 +++++++++++++++++++++++++------ > include/hw/boards.h | 1 + > include/sysemu/kvm.h | 10 ++++++++++ > kvm-all.c | 3 +++ > 4 files changed, 39 insertions(+), 6 deletions(-) Edgar/Peter, isn't Xilinx using -machine none in TCG mode? > @@ -78,20 +83,30 @@ static int accel_init_machine(AccelClass *acc, Ma= chineState *ms) > =20 > int configure_accelerator(MachineState *ms) > { > - const char *p; > + const char *p, *name; > char buf[10]; > int ret; > bool accel_initialised =3D false; > bool init_failed =3D false; > AccelClass *acc =3D NULL; > + ObjectClass *oc; > + bool probe_mode =3D false; > =20 > p =3D qemu_opt_get(qemu_get_machine_opts(), "accel"); > if (p =3D=3D NULL) { > - /* Use the default "accelerator", tcg */ > - p =3D "tcg"; > + oc =3D (ObjectClass *) MACHINE_GET_CLASS(current_machine); > + name =3D object_class_get_name(oc); > + probe_mode =3D !strcmp(name, "none" TYPE_MACHINE_SUFFIX); > + if (probe_mode) { > + /* Use these accelerators in probe mode, tcg should be l= ast */ > + p =3D probe_mode_accels; > + } else { > + /* Use the default "accelerator", tcg */ > + p =3D "tcg"; > + } > } Can't we instead use an explicit ,accel=3Dprobe or ,accel=3Dauto? That would then obsolete the next patch. Regards, Andreas > =20 > - while (!accel_initialised && *p !=3D '\0') { > + while ((probe_mode || !accel_initialised) && *p !=3D '\0') { > if (*p =3D=3D ':') { > p++; > } --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSQqi-000544-S2 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 08:57:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSQqa-0001WF-Vr for qemu-devel@nongnu.org; Mon, 02 Mar 2015 08:57:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55494 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSQqa-0001W8-QA for qemu-devel@nongnu.org; Mon, 02 Mar 2015 08:57:24 -0500 Message-ID: <54F46C41.3000201@suse.de> Date: Mon, 02 Mar 2015 14:57:21 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com> <1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com> In-Reply-To: <1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "Edgar E. Iglesias" , Peter Crosthwaite Cc: linux-s390@vger.kernel.org, Michael Mueller , kvm@vger.kernel.org, Gleb Natapov , Alexander Graf , Eduardo Habkost , linux-kernel@vger.kernel.org, Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Alistair Francis , Richard Henderson Am 02.03.2015 um 13:43 schrieb Michael Mueller: > QEMU now switches into "probe mode" when the selected machine is "none"= and no > specific accelerator(s) has been requested (i.e.: "-machine none"). >=20 > In probe mode a by "_CONFIG" defines predefined list of accelerat= ors run > their init() methods. >=20 > Signed-off-by: Michael Mueller > --- > accel.c | 31 +++++++++++++++++++++++++------ > include/hw/boards.h | 1 + > include/sysemu/kvm.h | 10 ++++++++++ > kvm-all.c | 3 +++ > 4 files changed, 39 insertions(+), 6 deletions(-) Edgar/Peter, isn't Xilinx using -machine none in TCG mode? > @@ -78,20 +83,30 @@ static int accel_init_machine(AccelClass *acc, Mach= ineState *ms) > =20 > int configure_accelerator(MachineState *ms) > { > - const char *p; > + const char *p, *name; > char buf[10]; > int ret; > bool accel_initialised =3D false; > bool init_failed =3D false; > AccelClass *acc =3D NULL; > + ObjectClass *oc; > + bool probe_mode =3D false; > =20 > p =3D qemu_opt_get(qemu_get_machine_opts(), "accel"); > if (p =3D=3D NULL) { > - /* Use the default "accelerator", tcg */ > - p =3D "tcg"; > + oc =3D (ObjectClass *) MACHINE_GET_CLASS(current_machine); > + name =3D object_class_get_name(oc); > + probe_mode =3D !strcmp(name, "none" TYPE_MACHINE_SUFFIX); > + if (probe_mode) { > + /* Use these accelerators in probe mode, tcg should be las= t */ > + p =3D probe_mode_accels; > + } else { > + /* Use the default "accelerator", tcg */ > + p =3D "tcg"; > + } > } Can't we instead use an explicit ,accel=3Dprobe or ,accel=3Dauto? That would then obsolete the next patch. Regards, Andreas > =20 > - while (!accel_initialised && *p !=3D '\0') { > + while ((probe_mode || !accel_initialised) && *p !=3D '\0') { > if (*p =3D=3D ':') { > p++; > } --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)