From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] platform/chrome: cros_ec_lpc - Depend on X86 || COMPILE_TEST
Date: Mon, 02 Mar 2015 14:58:24 +0100 [thread overview]
Message-ID: <54F46C80.8050906@collabora.co.uk> (raw)
In-Reply-To: <20150302134542.1a269fce@lxorguk.ukuu.org.uk>
Hello Alan,
On 03/02/2015 02:45 PM, One Thousand Gnomes wrote:
> On Fri, 27 Feb 2015 06:37:49 +0100
> Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote:
>
>> The Low Pin Count bus was introduced by Intel and is only used
>> in x86 computers
>
> The LPC bus is in all but name a slightly chopped down ISA bus. It is not
> x86 specific any more, and indeed there are wishbone/LPC busses used on
> all sorts of systems and processor types.
>
Thanks a lot for the clarification, I didn't know that.
> The ChromeOS EC may well be X86 specific but if so please fix the commit
> message accordingly.
>
I'll let the ChromiumOS folks to answer if EC connected through LPC will
only be used in x86 Chromebooks and non-x86 Chromebooks will always use
either SPI or I2C. Or if a non-x86 Chromebook with a EC connected through
LPC may exist in the future.
To know if I should either update the commit message or drop $subject,
since after patch 1/3 the driver builds correctly in other architectures.
> Alan
>
Best regards,
Javier
next prev parent reply other threads:[~2015-03-02 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 5:37 [PATCH 0/3] platform/chrome: cros_ec_lpc - Build fixes Javier Martinez Canillas
2015-02-27 5:37 ` [PATCH 1/3] platform/chrome: cros_ec_lpc - Include linux/io.h header file Javier Martinez Canillas
2015-02-27 5:37 ` [PATCH 2/3] platform/chrome: cros_ec_lpc - Depend on X86 || COMPILE_TEST Javier Martinez Canillas
2015-03-02 13:45 ` One Thousand Gnomes
2015-03-02 13:58 ` Javier Martinez Canillas [this message]
2015-03-04 19:27 ` Olof Johansson
2015-02-27 5:37 ` [PATCH 3/3] platform/chrome: cros_ec_lpc - Drop owner assignment Javier Martinez Canillas
2015-03-04 19:29 ` Olof Johansson
2015-03-04 20:24 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F46C80.8050906@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=dianders@chromium.org \
--cc=fengguang.wu@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gwendal@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.