From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 1/4] vscsiif.h: remove reference to WWN Date: Mon, 02 Mar 2015 15:55:56 +0100 Message-ID: <54F479FC.1090600@suse.com> References: <1425291362-30228-1-git-send-email-olaf@aepfle.de> <1425291362-30228-2-git-send-email-olaf@aepfle.de> <54F44282.1070009@suse.com> <20150302143439.GA18903@aepfle.de> <20150302144023.GB18903@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150302144023.GB18903@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Keir Fraser , Ian Campbell , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org On 03/02/2015 03:40 PM, Olaf Hering wrote: > On Mon, Mar 02, Olaf Hering wrote: > >> On Mon, Mar 02, Juergen Gross wrote: >> >>> On 03/02/2015 11:15 AM, Olaf Hering wrote: >>>> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. >>>> Remove incorrect reference to WWN because it was never supported. And >>>> its not clear how it could be supported. p-devname can be used to store >>>> a config string. >>> >>> The pvops backend driver should support the WWN notation. In case it >>> isn't working this is a bug which should be repaired. >>> >>> I implemented the WWn version before adding the possibility to use >>> h:c:t:l due to compatibility with xend... >> >> This requires changes to the libxl parser. I was not aware of that pvops >> uses such notation. > > And in fact it expects a colon in scsiback_add_translation_entry(). So > my patch is still valid. If another implementation comes along which > requires something else than h:c:t:l the comment will be adjusted. > But, maybe the comment is just incomplete and the WWN example lacks the > colon. I was just about to write this. :-) It should be: WWN:l (with l being the LUN). To be even more precise: The backend expects name:l. The name is checked against the WWN of the related device entry under /sys/kernel/config/target/core or against the contents of the alias entry under /sys/kernel/config/target/xen-pvscsi/*/tpgt_0/param/alias, so any string could be used as long as there is a match between the alias and the xenstore entry. "l" is in both cases the LUN number. Juergen