From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] monitor: Convert bdrv_find to blk_by_name
Date: Mon, 02 Mar 2015 10:30:04 -0500 [thread overview]
Message-ID: <54F481FC.1080101@redhat.com> (raw)
In-Reply-To: <1425296209-1476-2-git-send-email-famz@redhat.com>
On 2015-03-02 at 06:36, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> monitor.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 41900da..6ad777d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -72,6 +72,7 @@
> #include "block/qapi.h"
> #include "qapi/qmp-event.h"
> #include "qapi-event.h"
> +#include "sysemu/block-backend.h"
>
> /* for hmp_info_irq/pic */
> #if defined(TARGET_SPARC)
> @@ -5413,15 +5414,15 @@ int monitor_read_block_device_key(Monitor *mon, const char *device,
> BlockCompletionFunc *completion_cb,
> void *opaque)
> {
> - BlockDriverState *bs;
> + BlockBackend *blk;
>
> - bs = bdrv_find(device);
> - if (!bs) {
> + blk = blk_by_name(device);
> + if (!blk) {
> monitor_printf(mon, "Device not found %s\n", device);
> return -1;
> }
>
> - return monitor_read_bdrv_key_start(mon, bs, completion_cb, opaque);
> + return monitor_read_bdrv_key_start(mon, blk_bs(blk), completion_cb, opaque);
> }
>
> QemuOptsList qemu_mon_opts = {
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-03-02 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 11:36 [Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it Fam Zheng
2015-03-02 11:36 ` [Qemu-devel] [PATCH 1/4] monitor: Convert bdrv_find to blk_by_name Fam Zheng
2015-03-02 15:30 ` Max Reitz [this message]
2015-03-02 11:36 ` [Qemu-devel] [PATCH 2/4] migration: " Fam Zheng
2015-03-02 15:32 ` Max Reitz
2015-03-02 11:36 ` [Qemu-devel] [PATCH 3/4] blockdev: " Fam Zheng
2015-03-02 15:48 ` Max Reitz
2015-03-02 11:36 ` [Qemu-devel] [PATCH 4/4] block: Drop bdrv_find Fam Zheng
2015-03-02 15:51 ` Max Reitz
2015-03-03 20:47 ` [Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F481FC.1080101@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.