From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSSaQ-0006G7-VB for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:48:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSSaM-0005Wk-00 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:48:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSSaL-0005Wd-PO for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:48:45 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t22Fmj6e006873 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Mar 2015 10:48:45 -0500 Message-ID: <54F4865B.20105@redhat.com> Date: Mon, 02 Mar 2015 10:48:43 -0500 From: Max Reitz MIME-Version: 1.0 References: <1425296209-1476-1-git-send-email-famz@redhat.com> <1425296209-1476-4-git-send-email-famz@redhat.com> In-Reply-To: <1425296209-1476-4-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] blockdev: Convert bdrv_find to blk_by_name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi On 2015-03-02 at 06:36, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 92 ++++++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 59 insertions(+), 33 deletions(-) I think I touched the same problem in my "BB and media" series, and I think I replaced the bdrv_get_aio_context() calls by blk_get_aio_context() (because it looked nicer to me to call blk_bs() only after the AIO context has been acquired). However, at least before that series it is not possible to change the BDS attached to a BB while the BB is already in use in another AIO context, so: Reviewed-by: Max Reitz