All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch warning
Date: Mon, 2 Mar 2015 10:52:25 -0600	[thread overview]
Message-ID: <54F49549.5090706@ti.com> (raw)
In-Reply-To: <1425079647.2690.21.camel@perches.com>

On 02/27/2015 05:27 PM, Joe Perches wrote:
> On Fri, 2015-02-27 at 17:18 -0600, Suman Anna wrote:
>> Fix the following checkpatch warning,
>> WARNING: quoted string split across lines
>> +                "\n\t\tName of DSP firmware file in /lib/firmware"
>> +                " (if not specified defaults to 'rproc-dsp-fw')");
> []
>> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> []
>> @@ -26,8 +26,7 @@
>>  static char *da8xx_fw_name;
>>  module_param(da8xx_fw_name, charp, S_IRUGO);
>>  MODULE_PARM_DESC(da8xx_fw_name,
>> -		 "\n\t\tName of DSP firmware file in /lib/firmware"
>> -		 " (if not specified defaults to 'rproc-dsp-fw')");
>> +		 "\n\t\tName of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')");
> 
> There's probably no value in the leading "\n\t\t"

Agreed.

Ohad,
Let me know if you want that in a different patch, otherwise, you can
probably fix this up when applying.

regards
Suman



  reply	other threads:[~2015-03-02 16:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 23:18 [PATCH 0/3] remoteproc checkpatch fixes Suman Anna
2015-02-27 23:18 ` [PATCH 1/3] remoteproc/ste: add blank lines after declarations Suman Anna
2015-02-27 23:26   ` Joe Perches
2015-03-02 16:50     ` Suman Anna
2015-02-27 23:18 ` [PATCH 2/3] remoteproc/davinci: fix quoted split string checkpatch warning Suman Anna
2015-02-27 23:27   ` Joe Perches
2015-03-02 16:52     ` Suman Anna [this message]
2015-02-27 23:18 ` [PATCH 3/3] remoteproc: fix various checkpatch warnings Suman Anna
2015-05-02  8:16 ` [PATCH 0/3] remoteproc checkpatch fixes Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F49549.5090706@ti.com \
    --to=s-anna@ti.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.