From: Shuah Khan <shuahkh@osg.samsung.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [RFC][PATCH 00/19] Add timekeeping tests to kernel selftest
Date: Mon, 02 Mar 2015 10:21:27 -0700 [thread overview]
Message-ID: <54F49C17.8080804@osg.samsung.com> (raw)
In-Reply-To: <CALAqxLWNFbqr4bMe0zpKWPBwZVM7UFT--OeJ-oRUOMiz04crFg@mail.gmail.com>
On 03/02/2015 10:14 AM, John Stultz wrote:
> On Mon, Mar 2, 2015 at 9:06 AM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 02/25/2015 03:32 PM, John Stultz wrote:
>>> I've hosted my timekeeping tests on github for the last few years:
>>> https://github.com/johnstultz-work/timetests
>>>
>>> but I suspect not too many folks have actually used them.
>>>
>>> I've been meaning to get them reworked and submitted into the
>>> selftest infrastructure, but haven't had much time until
>>> recently. So I wanted to send this out and get any feedback
>>> to see if they might be able to get into shape for the 4.1
>>> merge window.
>>>
>>> I've added both the non-desctructive and destructive tests
>>> (which set the time, possibly to strange values, or tries
>>> to trigger historical issues that could crash the machine).
>>> The destructive tests are run (as root, or with proper
>>> privledge) via:
>>> # make run_destructive_tests
>>>
>>
>> I quickly browsed through the tests. Looks good to me. One
>> comment on test run scope. Since timers now include destructive
>> tests, run_tests target should only run the non-destructive by
>> default and destructive tests.
>
> Yes, agreed. That's why they are separated.
>
>> I didn't see the run_destructive_tests in this set of changes
>> in the timers/Makefile.
>
> ? See patch 10/19 for where run_destructive_tests gets introduced.
Sorry missed that one.
>
>> Please see cpu-hotplug and memory-hotplug as examples that
>> support default and full range tests.
>
> Would you rather the destructive tests be included in run_full_tests?
run_destructive_tests is just fine and appropriate for these tests.
>
> Other then that, I've got a few compiler warning cleanup and a fix for
> CROSS_COMPILE, so I'll resbumit the set tomorrow or later this week.
> So let me know if there are any other changes you'd like and I'll roll
> those in.
Please use kselftest.h reporting mechanism for new tests. posix_timers.c
is updated to use it and it would make sense use it for new tests as
well.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-03-02 17:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 22:32 [RFC][PATCH 00/19] Add timekeeping tests to kernel selftest John Stultz
2015-02-25 22:32 ` [PATCH 01/19] selftests/timers: Cleanup Makefile to make it easier to add future tests John Stultz
2015-03-02 17:08 ` Shuah Khan
2015-02-25 22:32 ` [PATCH 02/19] selftests/timers: Quiet warning due to lack of return check on brk John Stultz
2015-02-25 22:32 ` [PATCH 03/19] selftests/timers: Add nanosleep test from timetest suite John Stultz
2015-02-25 22:32 ` [PATCH 04/19] selftests/timers: Add inconsistency-check test from timetests John Stultz
2015-02-25 22:32 ` [PATCH 05/19] selftests/timers: Add nsleep-lat test from timetest suite John Stultz
2015-02-25 22:32 ` [PATCH 06/19] selftests/timers: Add clock skew estimation " John Stultz
2015-02-25 22:32 ` [PATCH 07/19] selftests/timers: Add set-timer-lat " John Stultz
2015-02-25 22:32 ` [PATCH 08/19] selftests/timers: Add threaded time inconsistency " John Stultz
2015-02-25 22:32 ` [PATCH 09/19] selftests/timers: Add mqueue latency test from the " John Stultz
2015-02-25 22:32 ` [PATCH 10/19] selftests/timers: Add adjtimex validation test from " John Stultz
2015-02-25 22:32 ` [PATCH 11/19] selftests/timers: Add alarmtimer-suspend test from timetests suite John Stultz
2015-02-25 22:32 ` [PATCH 12/19] selftests/timers: Add change_skew test from timetest suite John Stultz
2015-02-25 22:32 ` [PATCH 13/19] selftests/timers: Add skew_consistency test from the timetests suite John Stultz
2015-02-25 22:32 ` [PATCH 14/19] selftests/timers: Add clocksource-switch test from timetest suite John Stultz
2015-02-25 22:32 ` [PATCH 15/19] selftests/timers: Add leap-a-day " John Stultz
2015-02-25 22:32 ` [PATCH 16/19] selftests/timers: Add leapcrash test from the " John Stultz
2015-02-25 22:32 ` [PATCH 17/19] selftests/timers: Add set-tai " John Stultz
2015-02-25 22:32 ` [PATCH 18/19] selftests/timers: Add set-2038 test from " John Stultz
2015-02-25 22:32 ` [PATCH 19/19] MAINTAINERS: Add selftests/timers to the timekeeping maintainance list John Stultz
2015-03-01 18:28 ` [RFC][PATCH 00/19] Add timekeeping tests to kernel selftest Richard Cochran
2015-03-02 16:45 ` John Stultz
2015-03-02 17:06 ` Shuah Khan
2015-03-02 17:14 ` John Stultz
2015-03-02 17:21 ` Shuah Khan [this message]
2015-03-02 17:39 ` John Stultz
2015-03-02 17:46 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F49C17.8080804@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.