Re: [Outreachy kernel] [PATCH 1/4] Staging: rtl8188eu: Remove redundant if condition clause

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/02/15 01:22, Vatika Harlalka wrote:
> Clause removed as !sim_bitmap is always true.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
> index 2af3013..2bbdcca 100644
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -1025,7 +1025,7 @@ static bool simularity_compare(struct adapter *adapt, s32 resulta[][8],
>  		diff = (tmp1 > tmp2) ? (tmp1 - tmp2) : (tmp2 - tmp1);
>  
>  		if (diff > MAX_TOLERANCE) {
> -			if ((i == 2 || i == 6) && !sim_bitmap) {
> +			if (i == 2 || i == 6) {
>  				if (resulta[c1][i] + resulta[c1][i+1] == 0)
>  					final_candidate[(i/4)] = c2;
>  				else if (resulta[c2][i] + resulta[c2][i+1] == 0)
> 

How do you come to the conclusion that !sim_bitmap is always true here?
This is inside a for() loop, and once i > 0, sim_bitmap could be != 0.

NACK

Cheers,
Jes