From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 02 Mar 2015 19:32:23 +0100 Subject: [U-Boot] [PATCH] arm: imx: Fix conflicting definition types of 'get_reset_cause' In-Reply-To: <201503021927.46813.marex@denx.de> References: <1425319858-6748-1-git-send-email-otavio@ossystems.com.br> <201503021927.46813.marex@denx.de> Message-ID: <54F4ACB7.1090107@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, Otavio, On 02/03/2015 19:27, Marek Vasut wrote: > On Monday, March 02, 2015 at 07:10:58 PM, Otavio Salvador wrote: >> The common i.MX definition of 'get_reset_cause' function is non-static >> so the overriden ones should follow it. This fixes following error: >> >> ,---- >> >> | arch/arm/imx-common/cpu.c:29:14: error: static declaration >> | >> | of 'get_reset_cause' follows non-static declaration >> | static char *get_reset_cause(void) >> >> `---- >> >> The fix has been done in all i.MX based SoCs plus vf610. >> >> Fixes [YOCTO: #7384]. >> >> Signed-off-by: Otavio Salvador > > You should instead drop the prototype from sys_proto.h and repair > the only one non-static occurance in arch/arm/imx-common/cpu.c . > This is the fix I sent this morning: http://patchwork.ozlabs.org/patch/445002/ Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================