From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joel Schopp <joel.schopp@amd.com>
Subject: Re: [PATCH v2 1/2] kvm: x86: make kvm_emulate_* consistant
Date: Mon, 2 Mar 2015 13:20:42 -0600
Message-ID: <54F4B80A.5080103@amd.com>
References: <20150302180030.25137.83460.stgit@joelvmguard2.amd.com>
 <20150302180439.25137.12334.stgit@joelvmguard2.amd.com>
 <20150302190430.GC25123@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@alien8.de>,
	<linux-kernel@vger.kernel.org>, David Kaplan <david.kaplan@amd.com>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20150302190430.GC25123@potion.brq.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org


>> ---
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> @@ -4995,7 +4995,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu,
>>   		if (emulate_instruction(vcpu, 0) == EMULATE_DONE) {
>>   			if (vcpu->arch.halt_request) {
>>   				vcpu->arch.halt_request = 0;
>> -				return kvm_emulate_halt(vcpu);
>> +				return kvm_emulate_halt_noskip(vcpu);
> noskip is used without being declared ... it shouldn't compile.
I tested on AMD hardware, I thought I had turned on the Intel KVM module 
as well, but it turns out I hadn't.  Will fix in v3.

> *_noskip makes the usual case harder to undertand: we just want to halt
> the vcpu, so name it more directly ... like kvm_vcpu_halt()?
I like that better.  Will make the change in v3.