From: Josef Bacik <jbacik@fb.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 6/7] btrfs: quota: Automatically update related qgroups or mark INCONSISTENT flags when assigning/deleting a qgroup relations.
Date: Mon, 2 Mar 2015 17:02:46 -0500 [thread overview]
Message-ID: <54F4DE06.3060106@fb.com> (raw)
In-Reply-To: <1425025468-29749-7-git-send-email-quwenruo@cn.fujitsu.com>
On 02/27/2015 03:24 AM, Qu Wenruo wrote:
> Operation like qgroups assigning/deleting qgroup relations will mostly
> cause qgroup data inconsistent, since it needs to do the full rescan to
> determine whether shared extents are exclusive or still shared in
> parent qgroups.
>
> But there are some exceptions, like qgroup with only exclusive extents
> (qgroup->excl == qgroup->rfer), in that case, we only needs to
> modify all its parents' excl and rfer.
>
> So this patch adds a quick path for such qgroup in qgroup
> assign/remove routine, and if quick path failed, the qgroup status will
> be marked INCONSISTENT, and return 1 to info user-land.
>
> BTW since the quick path is much the same of qgroup_excl_accounting(),
> so move the core of it to __qgroup_excl_accounting() and reuse it.
>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Thanks,
Josef
next prev parent reply other threads:[~2015-03-02 22:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 8:24 [PATCH 0/7] Qgroup status flag fix and semi-automatic qgroup update on relationship assign Qu Wenruo
2015-02-27 8:24 ` [PATCH 1/7] btrfs: Check qgroup level in kernel qgroup assign Qu Wenruo
2015-03-02 21:49 ` Josef Bacik
2015-03-19 17:49 ` David Sterba
2015-02-27 8:24 ` [PATCH 2/7] btrfs: Don't allow subvolid >= (1 << BTRFS_QGROUP_LEVEL_SHIFT) to be created Qu Wenruo
2015-03-02 21:50 ` Josef Bacik
2015-02-27 8:24 ` [PATCH 3/7] btrfs: qgroup: Fix dead judgement on qgroup_rescan_leaf() return value Qu Wenruo
2015-03-02 21:52 ` Josef Bacik
2015-02-27 8:24 ` [PATCH 4/7] btrfs: Update btrfs qgroup status item when rescan is done Qu Wenruo
2015-03-02 21:54 ` Josef Bacik
2015-02-27 8:24 ` [PATCH 5/7] btrfs: qgroup: clear STATUS_FLAG_ON in disabling quota Qu Wenruo
2015-03-02 21:55 ` Josef Bacik
2015-02-27 8:24 ` [PATCH 6/7] btrfs: quota: Automatically update related qgroups or mark INCONSISTENT flags when assigning/deleting a qgroup relations Qu Wenruo
2015-03-02 22:02 ` Josef Bacik [this message]
2015-02-27 8:24 ` [PATCH 7/7] btrfs: quota: Update quota tree after qgroup relationship change Qu Wenruo
2015-03-02 22:03 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4DE06.3060106@fb.com \
--to=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.